Skip to content

Make deprecated magic method return properly #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocean90 merged 2 commits into from
Nov 25, 2020
Merged

Make deprecated magic method return properly #1206

ocean90 merged 2 commits into from
Nov 25, 2020

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Nov 17, 2020

To aid static analysis.

@szepeviktor szepeviktor mentioned this pull request Nov 17, 2020
Merged
@pedro-mendonca pedro-mendonca mentioned this pull request Nov 17, 2020
Merged
@szepeviktor szepeviktor changed the title Make deprecated __get() explicitly return null Make deprecated magic methods return properly Nov 17, 2020
@szepeviktor szepeviktor changed the title Make deprecated magic methods return properly Make deprecated magic method return properly Nov 17, 2020
@ocean90 ocean90 merged commit a96f298 into GlotPress:develop Nov 25, 2020
@ocean90 ocean90 added this to the 3.0 milestone Nov 25, 2020
@szepeviktor szepeviktor deleted the patch-1 branch November 25, 2020 15:36
pedro-mendonca pushed a commit to pedro-mendonca/GlotPress that referenced this pull request Dec 4, 2020
@szepeviktor @pedro-mendonca
Add default return value to GP_Locale::__get() (GlotPress#1206)
19c71df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @ocean90