Skip to content

Conversation

@naokomc
Copy link
Contributor

@naokomc naokomc commented Mar 24, 2020

Reference a section in the polyglots handbook instead of an old Goole link to fix #1021

Reference a section in the polyglots handbook instead of an old Goole link.
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the GlotPress handbook instead. I just sent an invite for the site. I guess https://glotpress.blog/the-manual/glossaries/ is a good place for this.

@toolstack toolstack added the [Type] Enhancement A suggestion for improvement. label Apr 1, 2020
@toolstack
Copy link
Contributor

I've created the appropriate page over at https://glotpress.blog/the-manual/glossaries/

@toolstack
Copy link
Contributor

@naokomc Could you update your PR with the new URL as well as address the CI failure?

Thanks.

@naokomc
Copy link
Contributor Author

naokomc commented Apr 4, 2020

@toolstack Thank you for the page on the manual. I've updated the URL.

@toolstack toolstack self-requested a review April 5, 2020 17:48
Copy link
Contributor

@toolstack toolstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@toolstack toolstack merged commit fd91c14 into GlotPress:develop Apr 5, 2020
<h2><?php _e( 'Import Glossary Entries', 'glotpress' ); ?></h2>
<p>
<?php printf( __( 'Use this form to bulk upload glossary entries. The entries should be stored in a CSV file, matching the custom glossary format from <a href="%s">Google Translator Toolkit</a>.', 'glotpress' ), 'https://support.google.com/translate/toolkit/answer/147854' ); ?><br/>
<?php printf( __( 'Use this form to bulk upload glossary entries. The entries should be stored in a CSV file with a custom glossary format. Read more on <a href="%s">Polyglots Handbook</a>.', 'glotpress' ), 'https://glotpress.blog/the-manual/glossaries/' ); ?><br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Polyglots Handbook" should have been replaced with "GlotPress handbook"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocean90 good point. This PR was closed - I just checked "Allow edits from maintainers." so that'll make it easier to update the text?
Sorry to take your time with this small change... 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a new PR for this and will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glossary import reference link no longer valid

3 participants