Skip to content

Glossary: No matches for single words of part_of_speech with no suffix rules #1790

@pedro-mendonca

Description

@pedro-mendonca

Description

For any types of glossary items (part of speech), if the entry has multiple words won't try to add any suffixes, and is immediately added to the glossary list.

As explained in Meta Ticket https://meta.trac.wordpress.org/ticket/7473, if the glossary entry is a single word, currently it will only be added if there are rules for suffixes, which is wrong. Even if there isn't any rule, at least the exact word should be added.

Step-by-step reproduction instructions

  1. Add single word glossary entry like "She" of part_of_speech "pronoun"
  2. Import a string with "She" in it.
  3. Check that there is no match
  4. Change the part_of_speech from "pronoun" to "noun"
  5. See that is accepted as it's returned by the gp_glossary_add_suffixes().

Expected behavior

The single pronoun "She" should be matched as any other single worded parts_of_speech.

Screenshots or screen recording (optional)

GlotPress information

  • GlotPress version: 4.0.0-beta.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Type] BugAn existing feature is broken.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions