Fix button margins after #1451 #1676
Labels
[Type] Bug
An existing feature is broken.
Milestone
Comments
samuelsidler
added a commit
to samuelsidler/GlotPress
that referenced
this issue
Aug 18, 2023
Buttons margins appear to have broken after GlotPress#1451 and are now misaligned. This adjusts them back to the pre-1451 state. Fixes GlotPress#1676.
Merged
|
@samuelsidler if we need the previous change in another instance like translate.w.org, we will do this improvement there, and not here, so it is ok to revert this change. I have checked it and:
I am going to approve and merge this PR. Thank you! |
amieiro
pushed a commit
that referenced
this issue
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Relevant Git Blame: https://github.com/GlotPress/GlotPress/blame/8f793a657e7bacda73f96cad267739cae5c1f334/assets/css/style.css#L336
In #1451, it appears the margins on buttons were changed, but it's unclear why they were changed. The additional margin makes all buttons appear misaligned within GlotPress, where previously they were vertically centred/aligned.
Examples:
@amieiro: Are there instances where this additional bottom margin is important? If so, can you target those instances specifically? I can't find any instances where this additional bottom margin is necessary.
The text was updated successfully, but these errors were encountered: