Skip to content

Minification: Improve workflow for Pull Requests that contain changes to JavaScript files #1587

@akirk

Description

@akirk

Right now, the minified files easily lead to conflicts when another PR with changes to the JS files has been merged. Can we improve this process?

My suggestion:

Remove minified files from develop and only generate and use them upon deploy to WordPress.org. This means we'd delete the minified files from the develop branch, change the SCRIPT_DEBUG if condition to add another constant and set this constant before deploying to .org.

e.g. $suffix = SCRIPT_DEBUG || ! GP_USE_MINIFIED ? '.css' : '.min.css';

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions