Skip to content

attributes for worktree-cache#818

Merged
Sebastian Thiel (Byron) merged 7 commits into
mainfrom
attributes-cache
Apr 24, 2023
Merged

attributes for worktree-cache#818
Sebastian Thiel (Byron) merged 7 commits into
mainfrom
attributes-cache

Conversation

@Byron

@Byron Sebastian Thiel (Byron) commented Apr 19, 2023

Copy link
Copy Markdown
Member

Make attribute access possible with the attribute cache.

Tasks

  • fix case-sensitivity handling for excludes (and validate for path/ excludes)
  • basic attributes access with baseline tests
  • basic attributes with selection

@Byron
Sebastian Thiel (Byron) force-pushed the attributes-cache branch 3 times, most recently from a252ed8 to 9ce5fb0 Compare April 20, 2023 06:43
This version works without a `search::pattern::List`.
It's useful to have to avoid certain conversions to happen otherwise.
…ly to git.

Previously directory excludes like `dir/` could (possibly) yield different results compared to git.
This is an opportunitstic change as it wasn't possible to trigger the wanted behaviour in a test
related to directory-specific matching. It did trigger, however, when matching normal patterns
which indicated there was indeed a bug.
Also, improve method documentation.
Otherwise it's not possible to keep allocations for matches,
while also adjusting pattern lists due to stack changes.

On the bright side, this adds some more deduplication to the implementation,
at the cost of dealing with some hashmaps that are updated when matching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant