Skip to content

handle case-insensitive file systems (those that apply folding rules)#341

Merged
Sebastian Thiel (Byron) merged 19 commits into
mainfrom
checkout-collisions
Mar 2, 2022
Merged

handle case-insensitive file systems (those that apply folding rules)#341
Sebastian Thiel (Byron) merged 19 commits into
mainfrom
checkout-collisions

Conversation

@Byron

@Byron Sebastian Thiel (Byron) commented Feb 24, 2022

Copy link
Copy Markdown
Member

Tasks

  • make sure it's clear the current implementation is only good for 'clone' mode due to many missing checks, probably with a mode enum.
  • checkstat and trustctime property - probably an fs feature
  • single-threaded collision reporting

@Byron Sebastian Thiel (Byron) changed the title detect issues with case-insensitive file systems (those that apply folding rules) and handle multi-threading correctly. handle case-insensitive file systems (those that apply folding rules) Feb 24, 2022
@Byron
Sebastian Thiel (Byron) force-pushed the checkout-collisions branch 3 times, most recently from 23405aa to 28bb4a3 Compare March 2, 2022 05:38
The latter should be useful when fully implementing all required
baseline capabilities of doing a correct checkout
This was probably a left-over from times where there was a static
requirement on the chunks processing. Maybe… .
For now they are unused but that should change when doing collision
checks.
Let's not try to imitate git here but instead solve the problem our
way while learning from bugs git ran into in the process.

This will be particularly interesting when dealing with parallel
checkouts, something we need to implement for sure.

On the bright side, there seems to be opportunity for a performance
boost due to less iops during clone.
It takes more than 60 seconds to run this test, which is odd but for
now it seems ok to just dial down the numbers a little.
@Byron
Sebastian Thiel (Byron) merged commit 8ca400c into main Mar 2, 2022
@Byron
Sebastian Thiel (Byron) deleted the checkout-collisions branch March 2, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant