Don't skip fuzzed_timeout on windows-11-arm#2619
Merged
Eliah Kagan (EliahKagan) merged 2 commits intoMay 26, 2026
Merged
Conversation
The `windows-11-arm` override in `test-fixtures-windows` passed `--skip fuzzed-timeout` (hyphen), which is not a substring of the actual test name `fuzzed_timeout` (underscore). `nextest`'s `--skip` matches by substring, so the intended skip was silently a no-op. Both overrides were added in 87a533e (GitoxideLabs#2115): `fuzzed_timeout` in `test-fast` and `fuzzed-timeout` in `test-fixtures-windows`. The silent no-op masked the typo through later edits to these lines. `fuzzed_timeout` therefore ran under `test-fixtures-windows` on `windows-11-arm` in each matrix job; the test asserts its runtime is under 2s on Windows, so whenever the matrix passes the per-job overhead has been within that bound. Align with the sibling override in `test-fast`, which already uses the underscore form. Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
The test runs in roughly 0.5s on `windows-11-arm` (sampled across recent successful `test-fixtures-windows` runs on `main`), too small to justify a matrix-specific skip. Drop `fuzzed_timeout` from the `--skip` list in both `test-fast` and `test-fixtures-windows` overrides. The other patterns (`performance` and `speed`) skip tests that run ~3.5 minutes each on `test-fixtures-windows (windows-latest)` and tend to take at least as long, often longer, on `windows-11-arm`. Those skips remain in place. Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to stop skipping the fuzzed_timeout/fuzzed-timeout test selection on the windows-11-arm runner, since the skip didn’t provide meaningful CI time savings.
Changes:
- Remove
--skip fuzzed_timeoutfrom thetest-fastjob when running onwindows-11-arm. - Remove
--skip fuzzed-timeoutfrom thetest-fixtures-windowsjob when running onwindows-11-arm. - Keep the existing
--skip performanceand--skip speedexclusions forwindows-11-arm.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eliah Kagan (EliahKagan)
marked this pull request as ready for review
May 26, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping
fuzzed-timeoutonwindows-11-armdid not save significant time--even once I fixed a bug introduced in 87a533e (#2115) when skipping them initially, where it wasn't actually skipped properly.The first commit here fixes the skip, so if we ever bring back the skip, we won't have the bug. The second commit removes the skip. The other two skips do save considerable time and are preserved. See commit messages for further details.
The code changes (to the workflow file) and commit messages (though not this PR description) were generated with Claude Code. The commit messages were carefully reviewed and iterated on, and I will also recheck both the diff and the commit messages one more time before merging this.