Add missing apt-get update in CI test job#1926
Merged
Eliah Kagan (EliahKagan) merged 1 commit intoApr 5, 2025
Merged
Conversation
The CI `test` job's "Setup dependencies" step had `apt-get install` without having previously run `apt-get update`. This often does not work, and in a CI environment one should not typically expect it to work because package indexes in a virtual machine just provisioned from an image, if present at all, may be very outdated. But for some reason it had been working until recently, when breakages were observed, including in GitoxideLabs#1924 (though the breakage is not related to the changes in that PR). This runs `apt-get update` before `apt-get install` in that CI job, as had already been done in the other CI jobs and as had likely always been intended. This should make the "Setup dependencies" step work again.
Eliah Kagan (EliahKagan)
enabled auto-merge
April 5, 2025 02:13
Eliah Kagan (EliahKagan)
left a comment
Eliah Kagan (EliahKagan)
left a comment
Member
Author
There was a problem hiding this comment.
As anticipated (and hoped), the "Setup dependencies" step in the full test job passed, both in this upstream repository on the pull_request trigger where the problem seemed like it might not always happen, and downstream in the branch on my fork on the push trigger where I know it was repeatedly occurring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI
testjob's "Setup dependencies" step hadapt-get installwithout having previously runapt-get update. This often does not work, and in a CI environment one should not typically expect it to work because package indexes in a virtual machine just provisioned from an image, if present at all, may be very outdated. But for some reason it had been working until recently, when breakages were observed, including in #1924 (though the breakage is not related to the changes in that PR).This runs
apt-get updatebeforeapt-get installin that CI job, as had already been done in the other CI jobs and as had likely always been intended. This should make the "Setup dependencies" step work again.The reason I'm doing this as a separate PR rather than by adding a commit to #1924 is that it simplifies testing the same thing both in this upstream repository and in my fork, which I think might prove valuable in case any further troubleshooting is needed. (Doing it as a separate PR probably also makes the history slightly clearer, since this change is independent of the rationale of #1924, but that's secondary.)
I plan to make sure the
testjob gets past the "Setup dependencies" step, and the enable auto-merge.