Fix clippy#1918
Merged
Merged
Conversation
Member
|
Thank you. Please feel free to merge this when it's ready. |
Eliah Kagan (EliahKagan)
force-pushed
the
fix-clippy
branch
from
April 4, 2025 01:21
19201b3 to
0c8dee3
Compare
Eliah Kagan (EliahKagan)
marked this pull request as ready for review
April 4, 2025 01:22
Eliah Kagan (EliahKagan)
enabled auto-merge
April 4, 2025 01:22
Member
Author
|
There's at least one other failure, which Edit: Running |
Eliah Kagan (EliahKagan)
force-pushed
the
fix-clippy
branch
from
April 4, 2025 01:43
0c8dee3 to
efb43fa
Compare
This removes some extra unnecessary semicolons that `clippy` has
recently begun to catch, causing CI to fail with errors such as:
error: unnecessary semicolon
--> gix-transport/src/client/blocking_io/http/traits.rs:30:18
|
30 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
= note: `-D clippy::unnecessary-semicolon` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_semicolon)]`
While it looks like this might first have been observed in GitoxideLabs#1917,
it is unrelated to any change there. It happens when the current
tip of main (4660f7a) is rerun, as observed in:
https://github.com/EliahKagan/gitoxide/actions/runs/14254079128/job/39958292846
This runs `just clippy-fix` and `etc/copy-packetline.sh` to fix it.
Eliah Kagan (EliahKagan)
force-pushed
the
fix-clippy
branch
from
April 4, 2025 01:46
efb43fa to
1370420
Compare
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clippyhas recently begun to fail with:While it looks like this might first have been observed in #1917, it is unrelated to any change there. It happens when the current tip of main (4660f7a) is rerun, as observed in:
https://github.com/EliahKagan/gitoxide/actions/runs/14254079128/job/39958292846
This is initially empty as I'm double checking that it does happen. I'll amend with a fix shortly.
Edit: Yes, it reproduces here. I've amended to add the fix.