fix pack receive#1731
Merged
Merged
Conversation
Sebastian Thiel (Byron)
marked this pull request as ready for review
December 20, 2024 18:57
Otherwise we will fail to produce a nice error message.
It became clear that the issue was home-made. The remote interactions of the 'free' variants never terminated the connection, which could have left the daemon hanging. It might have filled up its 32 slots, leading to rejection later, maybe.
Sebastian Thiel (Byron)
force-pushed
the
fix-pack-receive
branch
from
December 20, 2024 19:08
feaadb3 to
466fe52
Compare
It is possible for the negotiation to go on forever if implemented incorrectly on the client side. Hence it's useful to gracefully interrupt it.
Member
|
This worked out great--a bug is fixed and the tests are working again and reenabled for CI! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also re-enabled git-daemon on CI, which technically was just a workaround as it basically also didn't work locally.
In any case, now it works as it won't leave the server in a strange state due to not indicating the end of interaction.
My guess is that somehow the server would see its slots filled up with hanging processes, leading it to stop accepting
connections and probably also to stop going down.