Double the fixture lock timeout#1606
Merged
Sebastian Thiel (Byron) merged 1 commit intoSep 24, 2024
Merged
Conversation
This increases the lock timeout used in `gix-testtools` from 3 min 6 min. This seems to fix GitoxideLabs#1605.
Eliah Kagan (EliahKagan)
force-pushed
the
fixture-timeout
branch
from
September 24, 2024 09:59
a7e5a1c to
39323c3
Compare
Eliah Kagan (EliahKagan)
marked this pull request as ready for review
September 24, 2024 10:02
Sebastian Thiel (Byron)
approved these changes
Sep 24, 2024
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
Member
There was a problem hiding this comment.
Thanks a lot, I am glad this works.
And I am so looking forward to the day when there is a system that allows to keep issues, and reviews, and all metadata, directly in the repository and referenceable from commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1605
As suggested in #1605 (comment), this increases the lock timeout
gix-testtoolsuses when it runs fixture scripts.If 6 minutes is too long, I can experiment with intermediate values.
Duration::from_minsis still marked experimental in the standard library, so I've continued to useDuration::from_secswith* 60as before.