Make configure_command easier to call and comment about MSYS#1592
Merged
Sebastian Thiel (Byron) merged 3 commits intoGitoxideLabs:mainfrom Sep 11, 2024
Merged
Make configure_command easier to call and comment about MSYS#1592Sebastian Thiel (Byron) merged 3 commits intoGitoxideLabs:mainfrom
configure_command easier to call and comment about MSYS#1592Sebastian Thiel (Byron) merged 3 commits intoGitoxideLabs:mainfrom
Conversation
This makes the private `gix_testtools::configure_command` function generic (in type as well as lifetime) to accept anything as `args` that the `args` method of `std::process::Command` accepts. This also uses the broader parameter type to simplify a test.
I'm not sure if this is better, but the new genericity distracts less from what the function is really about when prsented this way.
This problem can be avoided by a design that doesn't create the assumption that such calls would have an effect, or that prevents them from being made (e.g. a builder funtion), or by accounting for and honoring them (which may involve reimplementing a fragment of the Windows API based case-folding that `std::process::Command` uses). But none of these approaches really seems overall better than what we are doing now. So for now, keep the design but note this one confusing spot. This is a private function, so I've just commented by where the relevant logic is, rather than using a `///` comment.
Sebastian Thiel (Byron)
approved these changes
Sep 11, 2024
Member
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Definitely an improvement, very nice, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No major design changes along the lines discussed in #1578 seemed like a decisive improvement; all of them had significant disadvantages. This instead:
configure_commandtake anything we can iterate to get arguments, rather than requiring a&[String]. This makes the current test simpler and easier to read, and should also help with future tests.envandenv_removecalls on theCommandobject where"MSYS"is the key, since we take it from our environment directly and modify that.There's slightly more thoughts in the commit messages. Also, I had trouble articulating why I thought 0e1e6a9 might be better here, since I don't usually prefer the more compact style, so maybe it's better without that change.