Rename to GIT_HIGHEST_SCOPE_CONFIG_PATH#1569
Merged
Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom Aug 31, 2024
Merged
Rename to GIT_HIGHEST_SCOPE_CONFIG_PATH#1569Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom
GIT_HIGHEST_SCOPE_CONFIG_PATH#1569Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom
Conversation
This renames the crate-internal static item with the cached path of the highest scope nonempty config, treated as associated with the `git` installation, from `GIT_HIGHEST_PRIORITY_CONFIG_PATH` to `GIT_HIGHEST_SCOPE_CONFIG_PATH`. This reflects the propensity of "priority" to have the opposite of the intended meaning here, since configuration in this file stands to be superseded by configuration in any lower (i.e. any other) scope. See GitoxideLabs#1568 for context. I think this change from "PRIORITY" to "SCOPE" in the name preserves the benefits of the change from `EXE_INFO` to `GIT_HIGHEST_PRIORITY_CONFIG_PATH` (dd2d666), while making clearer what is going on and avoiding misinterpretations.
Sebastian Thiel (Byron)
approved these changes
Aug 31, 2024
Member
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Thanks a lot - naming is hard 🤦♂️
Member
Author
Yes, and I'm not sure this one is the best possible name either. If I think of something better, I'll let you know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the crate-internal static item with the cached path of the highest scope nonempty config, treated as associated with the
gitinstallation, fromGIT_HIGHEST_PRIORITY_CONFIG_PATHtoGIT_HIGHEST_SCOPE_CONFIG_PATH.This reflects the propensity of "priority" to have the opposite of the intended meaning here, since configuration in this file stands to be superseded by configuration in any lower (i.e. any other) scope. See #1568 for context.
I think this change from "PRIORITY" to "SCOPE" in the name preserves the benefits of the change from
EXE_INFOtoGIT_HIGHEST_PRIORITY_CONFIG_PATH(dd2d666), while making clearer what is going on and avoiding misinterpretations.