Skip to content

fix mailmap parsing issue#1417

Merged
Sebastian Thiel (Byron) merged 4 commits into
mainfrom
fix-mailmap
Jun 23, 2024
Merged

fix mailmap parsing issue#1417
Sebastian Thiel (Byron) merged 4 commits into
mainfrom
fix-mailmap

Conversation

@Byron

@Byron Sebastian Thiel (Byron) commented Jun 23, 2024

Copy link
Copy Markdown
Member

Fixes #1416.

Tasks

  • reproduce issue
  • fix it
  • add mailmap check to the CLI

@Byron
Sebastian Thiel (Byron) marked this pull request as ready for review June 23, 2024 14:04

@emilazy Emily (emilazy) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more comprehensive than what I had started to write! I noticed one small issue.

Comment thread src/plumbing/options/mod.rs Outdated
@Byron
Sebastian Thiel (Byron) merged commit f107014 into main Jun 23, 2024
@Byron
Sebastian Thiel (Byron) deleted the fix-mailmap branch June 23, 2024 14:31
@Byron

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gix-mailmap parser treats mappings with old but not new names as an error

2 participants