pack write fix#1411
Merged
Merged
Conversation
…nes (#1404). That way, on Windows there is no chance for access-denied errors. Maybe there are other advantages as well even for Unix. Since packs are usually written rarely, in comparison to loose objects, the extra file accesss seems acceptable.
Sebastian Thiel (Byron)
force-pushed
the
fix-1404
branch
from
June 21, 2024 07:37
74a547a to
303724c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That way, on Windows there is no chance for access-denied errors. Maybe there are other advantages as well even for Unix.
Since packs are usually written rarely, in comparison to loose objects, the extra file accesss seems acceptable.