fix: sanitize labels correctly when using enviornment variables#5010
Merged
mergify[bot] merged 2 commits intoJul 2, 2026
Merged
Conversation
arturcic
approved these changes
Jul 2, 2026
Member
|
@robertcoltheart please rebase your changes onto main, and I will get it merged |
robertcoltheart
force-pushed
the
bug/fix-bad-semver-labels
branch
from
614d1fc to
2335da8
Compare
Member
|
hey @robertcoltheart mind to check why the tests are failing? |
auto-merge was automatically disabled
July 2, 2026 11:51
Head branch was pushed to by a user without write access
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Member
|
@Mergifyio queue |
Contributor
Merge Queue Status🛑 Queue command has been cancelled |
arturcic
force-pushed
the
bug/fix-bad-semver-labels
branch
from
784e096 to
ba1a715
Compare
Member
|
@Mergifyio refresh |
1 similar comment
Member
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
1 similar comment
Contributor
✅ Pull request refreshed |
|
Member
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 25 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you @robertcoltheart for your contribution! |
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using
{BranchName}formatting for labels correctly removes slashes and other non-compliant characters, but environment variables do not have the same sanitization applied. This fixes this to apply to environment variables as well.Related Issue
Resolves #5009
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: