Skip to content

CloseAllRunningPluginProcesses When the Standalone BF is Executed or …#4494

Merged
rathimayur merged 1 commit into
masterfrom
CloseAllRunningPluginProcesses_OnExecution_of_SingleBF_OR_RunsetEnd
May 29, 2026
Merged

CloseAllRunningPluginProcesses When the Standalone BF is Executed or …#4494
rathimayur merged 1 commit into
masterfrom
CloseAllRunningPluginProcesses_OnExecution_of_SingleBF_OR_RunsetEnd

Conversation

@rathimayur

@rathimayur rathimayur commented May 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

…At RunsetExecutionEnd

Description

Type of Change

  • Bug fix - [ ] New feature - [ ] Breaking change - [ ] Plugin update

Checklist

  • PR description clearly describes the changes
  • Target branch is correct (master for features, Releases/* for fixes)
  • Latest code from target branch merged
  • No commented/junk code included
  • No new build warnings or errors
  • All existing unit tests pass
  • New unit tests added for new functionality
  • Cross-platform compatibility verified (Windows/Linux/macOS)
  • CI/CD pipeline passes
  • Code follows project conventions (Act{Platform}{Type}, {Platform}Driver)
  • Repository objects use [IsSerializedForLocalRepository] where needed
  • Error handling uses Reporter.ToLog() pattern
  • Documentation updated for user-facing changes
  • Self-review completed and code review comments addressed

Summary by CodeRabbit

  • Bug Fixes
    • Plugin processes are now properly closed when execution sequences end, improving resource cleanup and preventing process leaks.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 553359ea-aebf-4bb1-ad95-5e8d85d3484b

📥 Commits

Reviewing files that changed from the base of the PR and between ed314b7 and 50e0c7a.

📒 Files selected for processing (2)
  • Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs
  • Ginger/GingerCoreNET/Run/RunsetExecutor.cs

Walkthrough

The PR adds plugin process cleanup to two execution termination paths. GingerExecutionEngine.RunBusinessFlow closes plugins after business flow completion in standalone mode. RunsetExecutor.RunRunset closes plugins after runset completion and environment cleanup. Both additions use the same WorkSpace.Instance.PlugInsManager.CloseAllRunningPluginProcesses() call.

Changes

Plugin Process Cleanup

Layer / File(s) Summary
Close plugin processes at execution termination
Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs, Ginger/GingerCoreNET/Run/RunsetExecutor.cs		 GingerExecutionEngine.RunBusinessFlow and RunsetExecutor.RunRunset both add CloseAllRunningPluginProcesses() calls in their respective cleanup sequences to ensure plugin processes are properly terminated when business flows or runsets complete.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Plugins dancing, now they rest,
Closed with care, cleaned up the best,
Two endpoints tidy, processes freed,
A cleanup ballet for all to heed!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete. While the template is present, the author only filled in the title continuation but left the Description section empty and did not select or describe the Type of Change, nor check any of the required checklist items. Provide a clear description of the changes, select the appropriate Type of Change option, and indicate which checklist items have been completed for this PR.
Title check ❓ Inconclusive The title partially describes the changes but is incomplete—it ends with 'or …' and doesn't fully convey that plugin processes are closed both at standalone BF execution end and at RunsetExecutionEnd. Complete the title to clearly state the full intent: 'Close all running plugin processes when standalone Business Flow executes or at RunsetExecutionEnd'
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch CloseAllRunningPluginProcesses_OnExecution_of_SingleBF_OR_RunsetEnd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production

codacy-production Bot commented May 25, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@rathimayur
rathimayur merged commit 218bdaa into master May 29, 2026
14 checks passed
@rathimayur
rathimayur deleted the CloseAllRunningPluginProcesses_OnExecution_of_SingleBF_OR_RunsetEnd branch May 29, 2026 12:39
@coderabbitai coderabbitai Bot mentioned this pull request Jun 17, 2026
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rathimayur