Add VE button to Path column in XML Tag Validation grid#4471
Merged
Conversation
Added a "..." button to each row in the Path column of the DynamicParametersGrid in ActXMLValidateTagsEditPage. Clicking the button opens the Value Expression Editor for the "Param" field of the selected row. Updated the event handler to support editing the correct field based on the button's Tag property.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdded a DataTemplate resource for a compact "Path" value-expression button and inserted a template column into the inputs grid; the click handler now null-checks the grid item and derives the target field name from the button Tag before opening the ValueExpressionEditorPage. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Ginger/Ginger/Actions/ActionEditPages/XML/ActXMLValidateTagsEditPage`
.xaml.cs:
- Line 97: The code currently returns silently when AIV is null; update the
conditional that contains "if (AIV == null) return;" (in the
ActXMLValidateTagsEditPage .xaml.cs method where AIV is checked) to log an error
before returning by calling Reporter.ToLog(eLogLevel.ERROR,
"ActXMLValidateTagsEditPage: AIV is null, aborting operation") (or a similar
contextual message) so the null-row path is recorded for supportability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 720212cc-2f44-4a17-b781-e987b9534b01
📒 Files selected for processing (2)
Ginger/Ginger/Actions/ActionEditPages/XML/ActXMLValidateTagsEditPage .xamlGinger/Ginger/Actions/ActionEditPages/XML/ActXMLValidateTagsEditPage .xaml.cs
Expanded the null check for ActInputValue (AIV) in the InputGridVEButton_Click event handler to use braces, improving code readability and consistency without changing functionality.
ravirk91
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a "..." button to each row in the Path column of the DynamicParametersGrid in ActXMLValidateTagsEditPage. Clicking the button opens the Value Expression Editor for the "Param" field of the selected row. Updated the event handler to support editing the correct field based on the button's Tag property.
Description
Type of Change
Checklist
[IsSerializedForLocalRepository]where neededReporter.ToLog()patternSummary by CodeRabbit
New Features
Bug Fixes
Improvements