Skip to content

License Updated#4320

Merged
Maheshkale447 merged 1 commit into
Releases/Official-Releasefrom
BugFix/LicenceUpdateNew
Oct 9, 2025
Merged

License Updated#4320
Maheshkale447 merged 1 commit into
Releases/Official-Releasefrom
BugFix/LicenceUpdateNew

Conversation

@prashelke

@prashelke prashelke commented Oct 6, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • Documentation
    • Added standardized license headers across multiple components to improve compliance and clarity.
  • Style
    • Aligned file headers and import ordering for consistency; no behavioral impact.
  • Tests
    • Updated test imports and references for consistency; no changes to test logic.
  • Chores
    • General housekeeping to align source files with licensing and formatting standards.

No user-facing changes in this release.

@coderabbitai

coderabbitai Bot commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Adds Apache 2.0 license header regions to multiple source files and adjusts using directive placement. Unit tests gain additional using directives, including a static import for ApplicationBackendVersion. No changes to public APIs, control flow, or runtime behavior.

Changes

Cohort / File(s) Summary of edits
CoreCommon headers
Ginger/GingerCoreCommon/External/Configurations/ZAPConfiguration.cs, Ginger/GingerCoreCommon/WorkSpaceLib/RepoFolderManager.cs		 Inserted license header regions; reordered/retained using directives; no logic or API changes.
ZAP components
Ginger/GingerCoreNET/External/ZAP/IZapClient.cs, Ginger/GingerCoreNET/External/ZAP/ZapClientWrapper.cs, Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs		 Added license header regions before using directives; no interface/signature or behavioral changes.
Logging
Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs		 Added license header region; moved using directive after header; no functional changes.
Unit tests
Ginger/GingerCoreNETUnitTest/SolutionRepositoryLib/SolutionUpgradeTest.cs, Ginger/GingerCoreNETUnitTest/ZAP/ZapProxyServiceTests.cs		 Added license headers; added using directives (including static import for ApplicationBackendVersion); no test logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Maheshkale447

Poem

A nibble of notes at the file’s bright top,
A hop, hop, hop—license drops!
No methods moved, no logic stirred,
Just tidy coats for every word.
Ears perked high, commit approved—
The rabbit stamps: “Headers improved!” 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description only contains the generic contributor checklist template and does not describe the actual changes made in this PR, such as adding license headers to specific files or explaining the intent behind these updates. Please update the PR description to include a concise summary of the license header additions, list the affected files, and explain why these changes are being made in line with the repository’s description template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “License Updated” directly relates to the main change of adding or updating license headers across the codebase and clearly signals the primary focus of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BugFix/LicenceUpdateNew
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c78046 and 483e2bb.

📒 Files selected for processing (8)
  • Ginger/GingerCoreCommon/External/Configurations/ZAPConfiguration.cs (1 hunks)
  • Ginger/GingerCoreCommon/WorkSpaceLib/RepoFolderManager.cs (1 hunks)
  • Ginger/GingerCoreNET/External/ZAP/IZapClient.cs (1 hunks)
  • Ginger/GingerCoreNET/External/ZAP/ZapClientWrapper.cs (1 hunks)
  • Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs (1 hunks)
  • Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs (1 hunks)
  • Ginger/GingerCoreNETUnitTest/SolutionRepositoryLib/SolutionUpgradeTest.cs (1 hunks)
  • Ginger/GingerCoreNETUnitTest/ZAP/ZapProxyServiceTests.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2025-08-25T08:48:11.915Z 
Learnt from: AmanPrasad43
PR: Ginger-Automation/Ginger#4281
File: Ginger/GingerCore/GingerCore.csproj:538-538
Timestamp: 2025-08-25T08:48:11.915Z
Learning: In the Ginger codebase, the OWASPZAPDotNetAPI package reference in GingerCore.csproj is required for architectural reasons, even when direct usage is not immediately visible in the codebase. This was confirmed by AmanPrasad43 during the security testing feature implementation.

Applied to files:

  • Ginger/GingerCoreNET/External/ZAP/ZapClientWrapper.cs
  • Ginger/GingerCoreNET/External/ZAP/IZapClient.cs
  • Ginger/GingerCoreNETUnitTest/ZAP/ZapProxyServiceTests.cs
📚 Learning: 2025-09-03T17:37:45.938Z 
Learnt from: AmanPrasad43
PR: Ginger-Automation/Ginger#4290
File: Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs:56-59
Timestamp: 2025-09-03T17:37:45.938Z
Learning: In the Ginger ZAP integration, the ZAP library's version API returns a string value, which is why the code uses ToString() to convert the IApiResponse to string format in the IsZapRunning method in ZapProxyService.cs.

Applied to files:

  • Ginger/GingerCoreNET/External/ZAP/ZapClientWrapper.cs
  • Ginger/GingerCoreNET/External/ZAP/IZapClient.cs
📚 Learning: 2025-06-16T10:37:13.073Z 
Learnt from: prashelke
PR: Ginger-Automation/Ginger#4232
File: Ginger/GingerCoreNET/ActionsLib/UI/VisualTesting/VRTAnalyzer.cs:19-22
Timestamp: 2025-06-16T10:37:13.073Z
Learning: In Ginger codebase, both `using amdocs.ginger.GingerCoreNET;` and `using Amdocs.Ginger.CoreNET;` are valid and serve different purposes. The first (lowercase) contains the WorkSpace class and related workspace functionality, while the second (proper case) contains drivers like GenericAppiumDriver and other core functionality. Both may be required in files that use types from both namespaces.

Applied to files:

  • Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs
  • Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs
📚 Learning: 2025-04-25T13:29:45.059Z 
Learnt from: GokulBothe99
PR: Ginger-Automation/Ginger#4188
File: Ginger/GingerCoreNET/RunLib/CLILib/DoOptionsHanlder.cs:22-23
Timestamp: 2025-04-25T13:29:45.059Z
Learning: The `using Amdocs.Ginger.Repository;` statement in Ginger/GingerCoreNET/RunLib/CLILib/DoOptionsHanlder.cs is necessary as it provides access to the `ObservableList<>` class which is used throughout the file for collections of RunSetConfig, AnalyzerItemBase, and ApplicationPOMModel objects.

Applied to files:

  • Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs
  • Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs
  • Ginger/GingerCoreCommon/External/Configurations/ZAPConfiguration.cs
📚 Learning: 2025-03-20T11:10:30.816Z 
Learnt from: GokulBothe99
PR: Ginger-Automation/Ginger#4137
File: Ginger/Ginger/SourceControl/SourceControlProjectsPage.xaml.cs:21-21
Timestamp: 2025-03-20T11:10:30.816Z
Learning: The `Amdocs.Ginger.Common.SourceControlLib` namespace is required in files that reference the `GingerSolution` class for source control operations in the Ginger automation framework.

Applied to files:

  • Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs
  • Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs
  • Ginger/GingerCoreCommon/External/Configurations/ZAPConfiguration.cs
📚 Learning: 2025-04-25T13:29:45.059Z 
Learnt from: GokulBothe99
PR: Ginger-Automation/Ginger#4188
File: Ginger/GingerCoreNET/RunLib/CLILib/DoOptionsHanlder.cs:22-23
Timestamp: 2025-04-25T13:29:45.059Z
Learning: The `using Amdocs.Ginger.Repository;` statement in Ginger/GingerCoreNET/RunLib/CLILib/DoOptionsHanlder.cs is necessary as it imports the ObservableList<> class which is used throughout the file.

Applied to files:

  • Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs
  • Ginger/GingerCoreCommon/External/Configurations/ZAPConfiguration.cs
🔇 Additional comments (8)
Ginger/GingerCoreNET/External/ZAP/ZapProxyService.cs (1)

1-17: License header added — OK

Apache 2.0 header placement and region look good. No functional impact.

Ginger/GingerCoreNET/log4netLib/HttpLogAppender.cs (1)

1-17: License header and using placement — OK

Header conforms to Apache 2.0; keeping using amdocs.ginger.GingerCoreNET; is correct for WorkSpace usage.

Based on learnings

Also applies to: 19-19

Ginger/GingerCoreNET/External/ZAP/IZapClient.cs (1)

1-17: License header and OWASPZAP import — OK

Header is correct; using OWASPZAPDotNetAPI; is required for IApiResponse in this interface.

Also applies to: 19-19

Ginger/GingerCoreNETUnitTest/ZAP/ZapProxyServiceTests.cs (1)

1-17: License header added — OK

Matches project standard; no test logic changes.

Ginger/GingerCoreCommon/External/Configurations/ZAPConfiguration.cs (1)

1-17: License header and repository using — OK

Header looks good; using Amdocs.Ginger.Repository; is necessary for RepositoryItemBase and attributes.

Based on learnings

Also applies to: 19-19

Ginger/GingerCoreNET/External/ZAP/ZapClientWrapper.cs (1)

1-17: LGTM!

The Apache 2.0 license header is properly formatted and consistent with the other files in this PR.

Ginger/GingerCoreCommon/WorkSpaceLib/RepoFolderManager.cs (1)

1-17: LGTM!

The Apache 2.0 license header is properly formatted and consistent with the other files in this PR.

Ginger/GingerCoreNETUnitTest/SolutionRepositoryLib/SolutionUpgradeTest.cs (1)

1-17: LGTM!

The Apache 2.0 license header is properly formatted and consistent with the other files in this PR.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Maheshkale447
Maheshkale447 merged commit 5b15825 into Releases/Official-Release Oct 9, 2025
14 of 17 checks passed
@Maheshkale447
Maheshkale447 deleted the BugFix/LicenceUpdateNew branch October 9, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maheshkale447 Maheshkale447 Maheshkale447 approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prashelke @Maheshkale447