JavaDriver/WidgetDropdown fix by GokulBothe99 · Pull Request #4316 · Ginger-Automation/Ginger

GokulBothe99 · 2025-10-01T09:07:33Z

Thank you for your contribution.
Before submitting this PR, please make sure:

Summary by CodeRabbit

Bug Fixes
- Fixed JNLP and JAR Java launch command assembly so additional parameters are appended correctly and quoted properly, improving launch reliability.
- Corrected web widget selection behavior so “Select” and “SelectByIndex” use the provided selection value, improving dropdown/selection accuracy.

coderabbitai · 2025-10-01T09:07:42Z

Walkthrough

Updates JNLP and JAR command assembly in the Java WS launcher to conditionally incorporate one-line parameters with adjusted quoting; updates JS widget selection so both "Select" and "SelectByIndex" use ValueToSelect, plus minor formatting/bracing edits.

Changes

Cohort / File(s)	Summary of Changes
Java WS Launch Command Handling `Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs`	When `URLExtensionType` is `JNLP`, sets command to `"<mURL_Calc>"` and, if `commandParams_OneLine` is present, removes a trailing quote, appends params, then re-adds the closing quote. When `JAR`, starts command with `-jar "<mURL_Calc>"` and appends params only inside that branch. Removed unconditional append of `commandParams_OneLine`.
Widget Selection Value Handling `Ginger/GingerCoreNET/Resources/JavaScripts/GingerHTMLHelper.js`	In widgets handling, both `"Select"` and `"SelectByIndex"` branches now assign `Value` from `inputValues.ValueToSelect`. Minor formatting/bracing changes only.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ActLaunch as ActLaunchJavaWSApplication
    participant Shell as ExecuteCommandSync

    Caller->>ActLaunch: Launch request (mURL_Calc + commandParams_OneLine)
    alt URLExtensionType == JNLP
        ActLaunch->>ActLaunch: command = "\"" + mURL_Calc + "\""
        alt commandParams_OneLine not empty
            ActLaunch->>ActLaunch: remove trailing '"' from command
            ActLaunch->>ActLaunch: append " " + commandParams_OneLine
            ActLaunch->>ActLaunch: add closing '"'
        end
    else URLExtensionType == JAR
        ActLaunch->>ActLaunch: command = "-jar \"" + mURL_Calc + "\""
        alt commandParams_OneLine not empty
            ActLaunch->>ActLaunch: append " " + commandParams_OneLine
        end
    end
    ActLaunch->>Shell: ExecuteCommandSync(finalCommand)
    Shell-->>ActLaunch: result
    ActLaunch-->>Caller: return result

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

Maheshkale447

Poem

I nibble at quotes and tuck params tight,
A gentle trim, then close at night.
Selects now borrow the value I bring,
A hop, a click — the launch takes wing. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “JavaDriver/WidgetDropdown fix” only references the widget dropdown change and omits the substantial modifications to the Java application launch logic, so it does not accurately summarize the main changes in this PR.	Please update the title to clearly reflect both the Java application launch command enhancements and the widget dropdown fix or split these into separate PRs so each title succinctly summarizes its respective change.
Description Check	⚠️ Warning	The PR description only repeats the repository’s generic contributor checklist and provides no details about what was actually changed, why it was changed, or how to verify it.	Please provide a description summarizing the purpose of the changes, the specific files and behaviors modified, and any testing or migration steps so reviewers can understand and validate the PR.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch Enhacement/JavaDriver

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11a012b and 682eaff.

📒 Files selected for processing (1)

Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs (1 hunks)

🔇 Additional comments (2)

Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs (2)
730-742: LGTM! JNLP parameter handling is correct.

The JNLP command construction correctly appends URL query parameters inside the quoted URL string, producing commands like:
"http://example.com/app.jnlp?param1=value1&param2=value2"
This is the expected format for JNLP URLs.

744-750: LGTM! JAR parameter handling correctly fixed.

The JAR command construction now properly appends parameters as separate quoted arguments after the JAR path. Since commandParams_OneLine already includes leading space and quoted params (built at lines 712, 723), the direct append produces:
-jar "path/to/app.jar" "param1=value1" "param2=value2"
This correctly addresses the critical issue raised in the previous review where parameters were being inserted inside the JAR path quotes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5d3652 and da21778.

📒 Files selected for processing (2)

Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs (2 hunks)
Ginger/GingerCoreNET/Resources/JavaScripts/GingerHTMLHelper.js (2 hunks)

🔇 Additional comments (2)

Ginger/GingerCoreNET/Resources/JavaScripts/GingerHTMLHelper.js (1)

174-181: No action needed on dropdown mapping
All callers—including UI edit pages, action conversion tests, web and Selenium drivers, and Java/Windows handlers—consistently set and consume ValueToSelect for both “Select” and “SelectByIndex” actions.

Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs (1)

730-748: Ignore unnecessary JNLP quoting. Removed quotes around the JNLP URL are correct: javaws.exe expects a percent-encoded URL (no raw spaces), and ProcessStartInfo.Arguments handles it without explicit wrapping.

Likely an incorrect or invalid review comment.

…omation/Ginger into Enhacement/JavaDriver

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da21778 and 11a012b.

📒 Files selected for processing (1)

Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs (1 hunks)

Defect ID 41264, 50270

a201423

Merge branch 'master' into Enhacement/JavaDriver

da21778

coderabbitai Bot requested changes Oct 1, 2025

View reviewed changes

Comment thread Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs Outdated

coderabbitai Bot previously approved these changes Oct 1, 2025

View reviewed changes

GokulBothe99 added 2 commits October 3, 2025 13:10

added double qoute after adding the command line argument

175fe0d

Merge branch 'Enhacement/JavaDriver' of https://github.com/Ginger-Aut…

11a012b

…omation/Ginger into Enhacement/JavaDriver

GokulBothe99 dismissed coderabbitai[bot]’s stale review via 11a012b October 3, 2025 07:44

coderabbitai Bot requested changes Oct 3, 2025

View reviewed changes

Comment thread Ginger/GingerCore/Actions/ActLaunchJavaWSApplication.cs Outdated

code change

682eaff

coderabbitai Bot approved these changes Oct 3, 2025

View reviewed changes

Merge branch 'master' into Enhacement/JavaDriver

fa752c4

Maheshkale447 merged commit d288013 into master Oct 3, 2025
4 of 5 checks passed

Maheshkale447 deleted the Enhacement/JavaDriver branch October 3, 2025 08:29

coderabbitai Bot mentioned this pull request Nov 20, 2025

Feature/jdk25 support #4363

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

JavaDriver/WidgetDropdown fix#4316

JavaDriver/WidgetDropdown fix#4316
Maheshkale447 merged 6 commits into
masterfrom
Enhacement/JavaDriver

GokulBothe99 commented Oct 1, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

GokulBothe99 commented Oct 1, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GokulBothe99 commented Oct 1, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 1, 2025 •

edited

Loading