Skip to content

Model Resource#4310

Merged
Maheshkale447 merged 1 commit into
masterfrom
Enhancment/PaddleOnlineModelOCR
Sep 21, 2025
Merged

Model Resource#4310
Maheshkale447 merged 1 commit into
masterfrom
Enhancment/PaddleOnlineModelOCR

Conversation

@AmanPrasad43

@AmanPrasad43 AmanPrasad43 commented Sep 21, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • Chores
    • Bundled additional OCR model assets (detection, classification, and recognition) for Chinese and English into the app’s build output.
    • Ensures these assets are copied during builds, improving out‑of‑the‑box availability of OCR functionality and reducing manual setup.
    • Aligns packaged runtime files to include the latest PP-OCRv4 and mobile classification models for broader coverage.
    • Minimizes likelihood of missing asset issues at runtime by consistently shipping required model files.

@coderabbitai

coderabbitai Bot commented Sep 21, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Adds PaddleOCR model asset files (det/cls/rec) to GingerCoreNET.csproj so they are copied to the build output (CopyToOutputDirectory=PreserveNewest). No code or public API changes.

Changes

Cohort / File(s) Summary
Build asset inclusion (OCR models)
Ginger/GingerCoreNET/GingerCoreNET.csproj
Added None items to copy PaddleOCR assets to output: ch_PP-OCRv4_det, ch_ppocr_mobile_v2.0_cls, en_PP-OCRv4_rec (inference.pdiparams, .info, .pdmodel, and ._inference.pdmodel) with PreserveNewest.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Ginger OCR Engine Change #4304 — Migrates OCR from Tesseract to PaddleOCR and adds related packages/assets; closely related to adding PaddleOCR model files to the project output.

Suggested reviewers

  • Maheshkale447

Poem

A rabbit packs models, neat and light,
Into the build for a sharper sight.
Det, cls, rec—hop, copy, go!
Output burrow ready to flow.
Ears up—OCR’s set just right.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Enhancment/PaddleOnlineModelOCR

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c7edca and d02ab8f.

📒 Files selected for processing (1)
  • Ginger/GingerCoreNET/GingerCoreNET.csproj (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Maheshkale447
Maheshkale447 merged commit 6e6ede6 into master Sep 21, 2025
0 of 5 checks passed
@Maheshkale447
Maheshkale447 deleted the Enhancment/PaddleOnlineModelOCR branch September 21, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants