Ginger/GingerCore/Actions/ActOcr.cs (4)

249-250: Remove unused backing property.

mGetFromRowNumber is never used; keep only GetFromRowNumber.

-        private string mGetFromRowNumber { get; set; } = "0";

---

293-294: Remove unused local.

dctOutput is declared but never used.

-            Dictionary<string, object> dctOutput = [];

---

348-349: Remove unused local.

Duplicate unused dctOutput here as well.

-            Dictionary<string, object> dctOutput = [];

---

387-394: Harden parsing of UseRowNumber and GetFromRowNumber to avoid runtime exceptions.

bool.Parse/int.Parse will throw on invalid/empty input (common when actions run headless). Default safely.

                 case eActOcrPdfOperations.ReadTextFromTableInPdf:
                     if (string.IsNullOrEmpty(GetFromRowNumber))
                     {
                         GetFromRowNumber = "0";
                     }
-                    resultText = GingerOcrOperations.ReadTextFromPdfTable(ValueExpression.Calculate(OcrFilePath), ValueExpression.Calculate(FirstString), ValueExpression.Calculate(PageNumber), bool.Parse(UseRowNumber),
-                        int.Parse(ValueExpression.Calculate(GetFromRowNumber)), ElementLocateBy, ValueExpression.Calculate(ConditionColumnName),
-                        ValueExpression.Calculate(ConditionColumnValue), decryptedPassword);
+                    // Safe parsing with defaults
+                    bool useRow = false;
+                    bool.TryParse(UseRowNumber, out useRow);
+                    int fromRow = 0;
+                    int.TryParse(ValueExpression.Calculate(GetFromRowNumber), out fromRow);
+                    if (fromRow < 0) fromRow = 0;
+
+                    resultText = GingerOcrOperations.ReadTextFromPdfTable(
+                        ValueExpression.Calculate(OcrFilePath),
+                        ValueExpression.Calculate(FirstString),
+                        ValueExpression.Calculate(PageNumber),
+                        useRow,
+                        fromRow,
+                        ElementLocateBy,
+                        ValueExpression.Calculate(ConditionColumnName),
+                        ValueExpression.Calculate(ConditionColumnValue),
+                        decryptedPassword);
                     if (!string.IsNullOrEmpty(resultText))
                     {
                         ProcessOutput(resultText);
                     }
                     else
                     {
                         Error = "Unable to read text from PDF";
                     }
                     break;

Ginger/Ginger/Actions/ActionEditPages/ActOcrEditPage.xaml.cs (2)

228-233: Bug: toggles reversed when “Select Column Value” radio is checked.

Currently sets UseRowNumber = true and enables Row Number fields instead of Column filters. Fix below.

-            mAct.UseRowNumber = rb.IsChecked.Value.ToString();
-            xRowNumber.IsEnabled = rb.IsChecked.Value;
-            xColumnWhere.IsEnabled = !rb.IsChecked.Value;
-            xColumnWhereValue.IsEnabled = !rb.IsChecked.Value;
-            xOperationCombo.IsEnabled = !rb.IsChecked.Value;
+            var isColumnValue = rb.IsChecked == true;
+            mAct.UseRowNumber = (!isColumnValue).ToString();
+            xRowNumber.IsEnabled = !isColumnValue;
+            xColumnWhere.IsEnabled = isColumnValue;
+            xColumnWhereValue.IsEnabled = isColumnValue;
+            xOperationCombo.IsEnabled = isColumnValue;

---

83-92: Store solution-relative path in the action — don’t convert back to full when saving

SolutionRepository.ConvertFullPathToBeRelative produces a solution-root relative path (prefixes with the solution-root sign) and GetFolderFullPath converts such relative paths back to absolute (SolutionRepository.cs — GetFolderFullPath ~line 392; ConvertFullPathToBeRelative ~line 421). In ActOcrEditPage.xaml.cs the browse handler currently does ConvertFullPathToBeRelative(fileName) then immediately calls GetFolderFullPath(fileName) and assigns that absolute path to mAct.OcrFilePath while displaying the relative path (browse handler, ActOcrEditPage.xaml.cs, ~lines 80–110). That stores an absolute path in the action and risks portability; ActSikuliEditPage stores the relative path instead (ActSikuliEditPage.xaml.cs ~line 151). Change the browse handler to store the relative path (assign fileName after ConvertFullPathToBeRelative) and resolve to full path only at execution time, or make this behavior consistent across actions.