Updated Token Url and app configuration#4298
Conversation
WalkthroughApp.config toggles LocalSetup from True to False. GingerPlayAPITokenManager stops forcing a trailing slash on the token endpoint, using the URL from GetGenerateTokenUrl() directly as HttpClient.BaseAddress. No other logic or signatures change. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
Ginger/Ginger/App.config(1 hunks)Ginger/GingerCoreNET/External/GingerPlay/GingerPlayAPITokenManager.cs(0 hunks)
💤 Files with no reviewable changes (1)
- Ginger/GingerCoreNET/External/GingerPlay/GingerPlayAPITokenManager.cs
🔇 Additional comments (2)
Ginger/Ginger/App.config (2)
14-14: Verify LocalSetup change and environment endpoints
LocalSetup is consumed in GingerCoreNET/External/GingerPlay/GingerPlayEndPointManager.cs (to choose local vs. hosted endpoints). Flipping it to False will route auth/URLs to non-local (Beta/Staging) services—confirm those endpoints are configured and reachable. The other App.config files (GingerHelper/App.config, GingerWPFDriverWindow/App.config) don’t define LocalSetup; ensure local/dev workflows aren’t broken or add matching entries or transforms if needed.
14-14: BuildServiceUrl correctly normalizes gateway URL and supports PostAsync("")
BuildServiceUrl appends a trailing slash toGingerPlayGatewayUrlbefore concatenatingconnect/token, yielding a full absolute URI. Setting this asHttpClient.BaseAddressand callingPostAsync("")resolves to that exact token endpoint without needing an extra slash.
| <add key="EXECUTION_SERVICE" value="ginger-execution"/> | ||
| <add key="IDENTITY_SERVICE" value="identity"/> | ||
| <add key="LocalSetup" value="True"/> | ||
| <add key="LocalSetup" value="False"/> |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Prefer per-environment config (transform or env-var override) over committing a global default.
Consider an App.Beta.config (SlowCheetah or pipeline transform) or environment-variable binding so Beta toggles don’t affect other branches/developers.
🤖 Prompt for AI Agents
Ginger/Ginger/App.config around line 14: the committed global default for
LocalSetup ("False") should not be the sole source of truth; instead create an
environment-specific override (e.g., App.Beta.config using SlowCheetah
transforms or an App.Beta.config transform in the build pipeline) or change the
app to read LocalSetup from an environment variable and fall back to the
existing value. Add the new App.Beta.config transform (or pipeline variable
binding) that sets LocalSetup as needed for Beta, update project build settings
to apply the transform for the Beta configuration, and remove reliance on a
committed global default so branches/developers are not affected.
2 participants
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit