External Configuration Pages Current Entity Saved items Issue fixed#4291
Merged
Maheshkale447 merged 2 commits intoSep 3, 2025
Merged
Conversation
Contributor
WalkthroughFive ExternalConfigurations pages now set WorkSpace.Instance.CurrentSelectedItem to the loaded configuration immediately after StartDirtyTracking() and before calling SetControls(); no public API or other logic changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Page as Config Page (Init)
participant WS as WorkSpace
participant UI as Controls
User->>Page: Open configuration page
activate Page
Page->>Page: StartDirtyTracking()
Page->>WS: Set CurrentSelectedItem = <ConfigInstance>
Note right of WS #DFF2E1: Workspace selection updated
Page->>UI: SetControls()
deactivate Page
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-08-28T09:27:18.793ZApplied to files:
📚 Learning: 2025-07-16T14:42:32.229ZApplied to files:
🧬 Code graph analysis (1)Ginger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.cs (1)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
Ginger/Ginger/ExternalConfigurations/AskLisaConfigurationsPage.xaml.cs (1)
90-99: Fix misleading comment (ClientId vs ClientSecret).The comment above xClientId handler references “client secret”.
Apply:
- // Encrypt the client secret unless it's already encrypted or a value expression. - // This ensures that sensitive data is stored securely without altering predefined expressions or duplicating encryption. + // Encrypt the client ID unless it's already encrypted or a value expression. + // Ensures sensitive data is stored securely without altering predefined expressions or duplicating encryption.Ginger/Ginger/ExternalConfigurations/GingerOpsConfigurationPage.xaml.cs (1)
68-71: Fix typo in user-facing validation text.“Identitiy” → “Identity”.
Apply:
- xISURLTextBox.ValueTextBox.AddValidationRule(new ValidateEmptyValue("Identitiy Service URL cannot be empty")); + xISURLTextBox.ValueTextBox.AddValidationRule(new ValidateEmptyValue("Identity Service URL cannot be empty"));Ginger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.cs (3)
63-66: Validation rule bound to wrong control and message mismatch.Rule added to API key textbox with “ZAP URL cannot be empty”. Add correct rules for both fields.
Apply:
- xZAPAPIkeyTextBox.ValueTextBox.AddValidationRule(new ValidateEmptyValue("ZAP URL cannot be empty")); + xZAPURLTextBox.ValueTextBox.AddValidationRule(new ValidateEmptyValue("ZAP URL cannot be empty")); + xZAPAPIkeyTextBox.ValueTextBox.AddValidationRule(new ValidateEmptyValue("ZAP API key cannot be empty"));
136-140: Possible compile-time issue: string.EndsWith('/') overload.Use string overload or char check.
Apply:
- if (zapUrl.EndsWith('/')) + if (zapUrl.EndsWith("/")) { zapUrl = zapUrl.TrimEnd('/'); }
144-146: Add a reasonable HTTP timeout.Avoid hanging UI on slow endpoints.
Apply:
- using HttpClient client = new HttpClient(); + using HttpClient client = new HttpClient(); + client.Timeout = TimeSpan.FromSeconds(15);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
Ginger/Ginger/ExternalConfigurations/AskLisaConfigurationsPage.xaml.cs(1 hunks)Ginger/Ginger/ExternalConfigurations/GingerOpsConfigurationPage.xaml.cs(1 hunks)Ginger/Ginger/ExternalConfigurations/GingerPlayConfigurationpage.xaml.cs(1 hunks)Ginger/Ginger/ExternalConfigurations/WireMockConfigurationPage.xaml.cs(1 hunks)Ginger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.cs(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-02-14T07:02:48.416Z
Learnt from: AmanPrasad43
PR: Ginger-Automation/Ginger#4100
File: Ginger/Ginger/ApplicationModelsLib/APIModels/APIModelWizard/AddAPIModelExtraConfigsPage.xaml:28-30
Timestamp: 2025-02-14T07:02:48.416Z
Learning: In AddAPIModelExtraConfigsPage.xaml, the WireMock mapping checkbox (xWireMockMappingToggle) is initially disabled and only gets enabled after successful validation of WireMock configuration and connection test in the CheckWireMockConfiguration method.
Applied to files:
Ginger/Ginger/ExternalConfigurations/WireMockConfigurationPage.xaml.cs
📚 Learning: 2025-07-16T14:42:32.229Z
Learnt from: prashelke
PR: Ginger-Automation/Ginger#4254
File: Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/LearnWizard/POMLearnConfigWizardPage.xaml.cs:70-73
Timestamp: 2025-07-16T14:42:32.229Z
Learning: In Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/LearnWizard/POMLearnConfigWizardPage.xaml.cs, prashelke prefers to keep the current `!WorkSpace.Instance.BetaFeatures.ShowPOMForAI` logic for binding and showing AI POM controls, rather than changing it to positive logic.
Applied to files:
Ginger/Ginger/ExternalConfigurations/WireMockConfigurationPage.xaml.csGinger/Ginger/ExternalConfigurations/GingerPlayConfigurationpage.xaml.csGinger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.csGinger/Ginger/ExternalConfigurations/AskLisaConfigurationsPage.xaml.csGinger/Ginger/ExternalConfigurations/GingerOpsConfigurationPage.xaml.cs
📚 Learning: 2025-08-28T09:27:18.793Z
Learnt from: AmanPrasad43
PR: Ginger-Automation/Ginger#4286
File: Ginger/Ginger/Drivers/DriversConfigsEditPages/WebAgentConfigEditPage.xaml.cs:556-571
Timestamp: 2025-08-28T09:27:18.793Z
Learning: In Ginger's WebAgentConfigEditPage.xaml.cs ZAP configuration, when ZAP Security Testing is enabled, the manual proxy UI should remain enabled/accessible even though ZAP will override the proxy settings in the background. This allows users to see and modify their proxy configurations for transparency and future use when ZAP is disabled. Confirmed by AmanPrasad43 in PR #4286.
Applied to files:
Ginger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.cs
🧬 Code graph analysis (5)
Ginger/Ginger/ExternalConfigurations/WireMockConfigurationPage.xaml.cs (1)
Ginger/GingerCoreNET/WorkSpaceLib/WorkSpace.cs (1)
WorkSpace(61-1006)
Ginger/Ginger/ExternalConfigurations/GingerPlayConfigurationpage.xaml.cs (1)
Ginger/GingerCoreNET/WorkSpaceLib/WorkSpace.cs (1)
WorkSpace(61-1006)
Ginger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.cs (1)
Ginger/GingerCoreNET/WorkSpaceLib/WorkSpace.cs (1)
WorkSpace(61-1006)
Ginger/Ginger/ExternalConfigurations/AskLisaConfigurationsPage.xaml.cs (1)
Ginger/GingerCoreNET/WorkSpaceLib/WorkSpace.cs (1)
WorkSpace(61-1006)
Ginger/Ginger/ExternalConfigurations/GingerOpsConfigurationPage.xaml.cs (1)
Ginger/GingerCoreNET/WorkSpaceLib/WorkSpace.cs (1)
WorkSpace(61-1006)
🔇 Additional comments (5)
Ginger/Ginger/ExternalConfigurations/WireMockConfigurationPage.xaml.cs (1)
46-49: Set CurrentSelectedItem after StartDirtyTracking — good.This aligns save/dirty context with the loaded WireMockConfiguration and matches the PR’s intent.
Ginger/Ginger/ExternalConfigurations/GingerPlayConfigurationpage.xaml.cs (1)
52-55: Correct placement of CurrentSelectedItem.Assigned immediately after StartDirtyTracking and before bindings. Looks good.
Ginger/Ginger/ExternalConfigurations/AskLisaConfigurationsPage.xaml.cs (1)
46-49: Consistent selection update.Setting CurrentSelectedItem after StartDirtyTracking matches the pattern across pages.
Ginger/Ginger/ExternalConfigurations/GingerOpsConfigurationPage.xaml.cs (1)
47-50: Selection set post-StartDirtyTracking — OK.Ensures workspace points at the edited GingerOpsConfiguration.
Ginger/Ginger/ExternalConfigurations/ZAPConfigurationPage.xaml.cs (1)
48-49: Selection update is correct.Assigned after StartDirtyTracking; aligns with other pages.
Maheshkale447
approved these changes
Sep 3, 2025
Maheshkale447
deleted the
BugFix/ExternalIntegrationCurrentSavingDirtyMark
branch
September 3, 2025 16:46
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit