Remove the publish for Action and added relevant field#4243
Conversation
WalkthroughA conditional exclusion was added to remove the "Publish" attribute from editable member names for "Action" items in the Find and Replace page. Additionally, the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FindAndReplacePage
participant Act
User->>FindAndReplacePage: Selects main item type ("Action")
FindAndReplacePage->>FindAndReplacePage: Remove "Publish" from attribute list
User->>Act: Edits Active/Description/RunDescription properties
Act-->>User: Properties marked as editable via AllowUserToEdit attribute
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Ginger/Ginger/Functionalities/FindAndReplacePage.xaml.cs(1 hunks)Ginger/GingerCoreCommon/Actions/Act.cs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Ginger/GingerCoreCommon/Actions/Act.cs (1)
Learnt from: GokulBothe99
PR: Ginger-Automation/Ginger#4226
File: Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs:234-238
Timestamp: 2025-06-13T12:50:36.132Z
Learning: In the Ginger codebase, the `[AllowUserToEdit("<Label>")]` attribute is intentionally supplied with a string that represents the display label (e.g., `"Description"`, `"Active"`), not a default value. Suggestions to remove or change this parameter should be avoided unless the label itself is incorrect.
🔇 Additional comments (3)
Ginger/GingerCoreCommon/Actions/Act.cs (3)
163-165: User-editable flag added correctly toActiveThe
[AllowUserToEdit("Active")]attribute is consistent with existing conventions (string label equals the display caption). No further action required.
169-171:Descriptionis now exposed for in-place editing – verify downstream toolingExposing this field in the UI is desirable, but double-check:
- Validation logic that previously assumed the property was read-only.
- Any grid / form layouts that need column width or tooltip adjustments.
Otherwise, change looks good.
173-175: Minor inconsistency in display label
[AllowUserToEdit("Run Description")]introduces a space that does not exist in the backing constant (Fields.RunDescription).
If this string is only a UI caption it’s harmless; if it is also used as a key, consider aligning it:-[AllowUserToEdit("Run Description")] +[AllowUserToEdit("RunDescription")]Feel free to ignore if the space is intentional for readability.
⛔ Skipped due to learnings
Learnt from: GokulBothe99 PR: Ginger-Automation/Ginger#4226 File: Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs:234-238 Timestamp: 2025-06-13T12:50:36.132Z Learning: In the Ginger codebase, the `[AllowUserToEdit("<Label>")]` attribute is intentionally supplied with a string that represents the display label (e.g., `"Description"`, `"Active"`), not a default value. Suggestions to remove or change this parameter should be avoided unless the label itself is incorrect.
2 participants
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit
New Features
Bug Fixes