Master update post Beta release#4240
Merged
Merged
Conversation
Beta branch update
Handled Git multiple branch issue
Adding take a screenshot func for images of screen elements in mobile
Defect fixes of Mobile Accessibility Analyzer
- Introduced `TryFetchAsync` in `HttpUtilities.cs` for improved asynchronous HTTP GET requests with enhanced error handling and logging. - Updated version in `GingerCoreCommon.csproj` from `2025.3.0-Beta.1` to `2025.3.1-Beta.1`. - Modified `LoadLinkedActivities` in `BusinessFlow.cs` to accept an optional `SolutionRepository` parameter for more flexible activity retrieval.
VRT Fixed and Not supported Log Added
dropdown disabled while loading the data
…llableScreenshotFixed D48585_Scrollable Screenshot fixed
Enhance encryption handling in ParameterConfigHelper Updated ParameterConfigHelper.cs to add encryption checks for parameter values. Now decrypts values when creating parameters and handles encryption for VariablePasswordString during updates, improving security for sensitive information.
Ginger Play password Set
Updated to use target-typed `new()` for list creation. Introduced `FormatInputValue` helper function to improve readability and reduce code duplication. Refactored processing logic for `mAction.InputValues` and enhanced clarity in handling additional input value lists with explicit loops. Overall improvements to maintainability and adherence to modern C# practices.
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces improvements to mobile accessibility testing, UI state management, and HTTP request handling. It adds element-level screenshot capture for mobile UI, refines accessibility rule filtering and reporting, enhances HTTP GET retry logic, and implements UI control disabling during asynchronous operations. Several method signatures and collection types are updated for consistency and extensibility. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant FindAndReplacePage
User->>UI: Initiates Find operation
UI->>FindAndReplacePage: Call FindItemsAsync_item()
FindAndReplacePage->>FindAndReplacePage: Set IsLoading = true (disable controls)
FindAndReplacePage->>FindAndReplacePage: Perform async find logic
FindAndReplacePage->>FindAndReplacePage: Set IsLoading = false (enable controls)
FindAndReplacePage->>UI: Update UI with results
sequenceDiagram
participant TestRunner
participant GenericAppiumDriver
participant MobileAccessibilityAnalyzer
TestRunner->>GenericAppiumDriver: GetVisibleControls()
GenericAppiumDriver->>GenericAppiumDriver: Capture full-page screenshot
loop For each element
GenericAppiumDriver->>GenericAppiumDriver: Crop screenshot for element
GenericAppiumDriver->>ElementInfo: Assign cropped image as base64
end
GenericAppiumDriver->>TestRunner: Return elements with screenshots
TestRunner->>MobileAccessibilityAnalyzer: AnalyzerMobileAccessibility(driver, context, ...)
MobileAccessibilityAnalyzer->>MobileAccessibilityAnalyzer: Analyze accessibility
MobileAccessibilityAnalyzer->>MobileAccessibilityAnalyzer: Embed screenshot in report
MobileAccessibilityAnalyzer->>TestRunner: Return analysis results
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (13)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
15 tasks
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Refactor
Chores