Skip to content

Changed the Clipboard Get and Set logic.#4220

Merged
Maheshkale447 merged 1 commit into
masterfrom
BugFix-ClipboardNotWorkingPB-on-Grid-Actions
May 19, 2025
Merged

Changed the Clipboard Get and Set logic.#4220
Maheshkale447 merged 1 commit into
masterfrom
BugFix-ClipboardNotWorkingPB-on-Grid-Actions

Conversation

@rathimayur

@rathimayur rathimayur commented May 19, 2025

Copy link
Copy Markdown
Contributor

We experienced an issue while reading the Clipboard text on Azure Cloud Hosted VDI Windows Server.
To fix this, using a fallback mechanism to read Clipboard text using a different git nugget.

Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • Refactor

    • Updated clipboard operations in chat message copying to use a helper method for improved consistency.
    • Enhanced clipboard text retrieval logic to include a fallback mechanism and additional debug logging for better traceability.
  • Bug Fixes

    • Improved reliability of clipboard interactions when copying chat messages or retrieving clipboard text.

@coderabbitai

coderabbitai Bot commented May 19, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This update replaces direct system clipboard API calls with encapsulated helper methods for setting and getting clipboard text in chat-related and UI automation components. Additional debug logging is introduced for clipboard operations, and clipboard retrieval is refactored to include a fallback mechanism using a separate STA-thread with improved exception handling.

Changes

File(s) Change Summary
Ginger/Ginger/UserControlsLib/ChatBot/ChatbotWindow.xaml.cs Replaced direct Clipboard.SetText calls with GingerCore.General.SetClipboardText for copying chat messages.
Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs Added debug logging for clipboard operations; refactored clipboard retrieval to use helper with fallback and logging.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ChatbotWindow
    participant GingerCore.General

    User->>ChatbotWindow: Clicks "Copy" or "Copy All"
    ChatbotWindow->>GingerCore.General: SetClipboardText(text)
    GingerCore.General-->>ChatbotWindow: Clipboard updated
Loading
sequenceDiagram
    participant UIAutomation
    participant GingerCore.General
    participant Clipboard (STA Thread)

    UIAutomation->>GingerCore.General: GetClipboardText()
    alt Clipboard text available
        GingerCore.General-->>UIAutomation: Return clipboard text
    else Clipboard text not available
        GingerCore.General->>Clipboard (STA Thread): GetText(TextDataFormat.Text)
        Clipboard (STA Thread)-->>GingerCore.General: Return clipboard text or exception
        GingerCore.General-->>UIAutomation: Return clipboard text or log error
    end
Loading

Possibly related PRs

Suggested reviewers

  • Maheshkale447

Poem

A bunny with code so neat and bright,
Hopped to the clipboard, set things right.
With wrappers and logs, it pranced along,
Ensuring clipboard bugs are gone.
In threads it danced, in chat it cheered—
Clipboard magic, as the bunny engineered!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06551f5 and 8c481a1.

📒 Files selected for processing (2)
  • Ginger/Ginger/UserControlsLib/ChatBot/ChatbotWindow.xaml.cs (2 hunks)
  • Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs (2 hunks)
🔇 Additional comments (4)
Ginger/Ginger/UserControlsLib/ChatBot/ChatbotWindow.xaml.cs (2)

236-236: Standardize clipboard write via central helper
Replacing the direct API with GingerCore.General.SetClipboardText here ensures consistent error handling and STA-thread fallback across the app. This aligns perfectly with the PR objective to centralize clipboard logic.


373-373: Use wrapper for “Copy All” functionality
Good to see the copy‐all action now delegating to GingerCore.General.SetClipboardText. This maintains consistency with individual message copy behavior and leverages the new fallback mechanism.

Ginger/GingerCore/Actions/UIAutomation/UIAComWrapperHelper.cs (2)

4092-4092: Good addition of detailed debug logging.

This debug log will help in troubleshooting clipboard functionality issues by showing the actual text copied from the clipboard during execution.


4106-4135: Nice implementation of a clipboard access fallback mechanism.

This is a robust improvement that:

  1. First attempts to use the central helper method GingerCore.General.GetClipboardText()
  2. Logs appropriate debug information when falling back to alternative method
  3. Creates a separate STA thread for clipboard access (required for clipboard operations in COM)
  4. Properly handles thread synchronization with a completion flag
  5. Includes exception handling to prevent crashes

This change addresses the stated goal of improving clipboard text handling reliability in Azure Cloud Hosted VDI Windows Server environments.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch BugFix-ClipboardNotWorkingPB-on-Grid-Actions
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rathimayur
rathimayur requested a review from Maheshkale447 May 19, 2025 09:11
@Maheshkale447
Maheshkale447 merged commit ad06927 into master May 19, 2025
@Maheshkale447
Maheshkale447 deleted the BugFix-ClipboardNotWorkingPB-on-Grid-Actions branch May 19, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants