Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

Ginger/GingerCoreNET/ActionsLib/ActPublishArtifacts.cs (1)

71-102: 🛠️ Refactor suggestion

Set action status explicitly on success or failure.

The method currently sets error messages but doesn't explicitly set the action's status. This was mentioned in a previous review comment that hasn't been fully addressed.

public override void Execute()
{
+   bool hasErrors = false;
    try
    {
        if (ActInputValues == null || ActInputValues.Count == 0)
        {
            Error = "No artifact files provided.";
+           hasErrors = true;
            return;
        }

        foreach (ActInputValue item in ActInputValues)
        {
            if (!System.IO.File.Exists(item.ValueForDriver))
            {
                Error += "Artifact File Path is invalid/doesn't exist/not enough permissions to access file: " + item.ValueForDriver;
+               hasErrors = true;
                continue;
            }
            if (new System.IO.FileInfo(item.ValueForDriver).Length > 5242879) // 5MB = 5242880 bytes, but somewhere the calculation is referring it as 5242879 bytes
            {
                Error += "File size greater than 5MB cannot be uploaded: " + item.ValueForDriver;
+               hasErrors = true;
                continue;
            }

            Act.AddArtifactToAction(Path.GetFileName(item.ValueForDriver), this, item.ValueForDriver);
        }
    }
    catch (Exception ex)
    {
        Error += "Failed to upload artifacts: " + ex;
+       hasErrors = true;
        return;
    }
+   
+   if (hasErrors)
+   {
+       Status = Amdocs.Ginger.CoreNET.Execution.eRunStatus.Failed;
+   }
+   else
+   {
+       Status = Amdocs.Ginger.CoreNET.Execution.eRunStatus.Passed;
+   }
}

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

Ginger/GingerCoreNET/ActionsLib/ActPublishArtifacts.cs (3)

3-3: Update copyright year to the current year.

The copyright year extends to 2025, which is in the future. Update it to the current year (2024).

-Copyright © 2014-2025 European Support Limited
+Copyright © 2014-2024 European Support Limited

---

95-95: 🧹 Nitpick (assertive)

Improve error message to include file size information.

When a file exceeds the size limit, it would be helpful to include the actual file size in the error message for better diagnostics.

-                            Error += $"File size greater than 5MB cannot be uploaded: {item.ValueForDriver}";
+                            Error += $"File size greater than 5MB cannot be uploaded: {item.ValueForDriver} (Size: {fileSize/(1024.0*1024.0):F2} MB)";

---

73-113: 🛠️ Refactor suggestion

Set action status based on error condition.

The Execute method collects errors but doesn't explicitly set the action's status to failed when errors occur. This could lead to inconsistent behavior if the caller doesn't check the Error property.

public override void Execute()
{
    try
    {
+       bool hasErrors = false;
        if (ActInputValues == null || ActInputValues.Count == 0)
        {
            Error = "No artifact files provided.";
+           Status = Amdocs.Ginger.CoreNET.Execution.eRunStatus.Failed;
            return;
        }

        foreach (ActInputValue item in ActInputValues)
        {
            if (!System.IO.File.Exists(item.ValueForDriver))
            {
                Error += $"Artifact File Path is invalid/doesn't exist/not enough permissions to access file: {item.ValueForDriver}";
+               hasErrors = true;
                continue;
            }
            try
            {
                var fileSize = new System.IO.FileInfo(item.ValueForDriver).Length;
                if (fileSize > MaxUploadSizeBytes)
                {
                    Error += $"File size greater than 5MB cannot be uploaded: {item.ValueForDriver}";
+                   hasErrors = true;
                    continue;
                }
            }
            catch (Exception ex)
            {
                Error += $"Failed to check file size for {item.ValueForDriver}: {ex.Message}";
+               hasErrors = true;
                continue;
            }

            Act.AddArtifactToAction(Path.GetFileName(item.ValueForDriver), this, item.ValueForDriver);
        }
+       
+       if (hasErrors)
+       {
+           Status = Amdocs.Ginger.CoreNET.Execution.eRunStatus.Failed;
+       }
+       else
+       {
+           Status = Amdocs.Ginger.CoreNET.Execution.eRunStatus.Passed;
+       }
    }
    catch (Exception ex)
    {
        Error += $"Failed to upload artifacts: {ex.Message}";
+       Status = Amdocs.Ginger.CoreNET.Execution.eRunStatus.Failed;
        return;
    }
}

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro