Skip to content

Update POM running status ,disabled Grid After Run run set#4177

Merged
Maheshkale447 merged 1 commit into
Releases/Betafrom
BugFix/MultiPOMHungIssueFixed
Apr 10, 2025
Merged

Update POM running status ,disabled Grid After Run run set#4177
Maheshkale447 merged 1 commit into
Releases/Betafrom
BugFix/MultiPOMHungIssueFixed

Conversation

@prashelke

@prashelke prashelke commented Apr 10, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

  • New Features
    • Improved the wizard experience by temporarily disabling interactive elements during runset execution, ensuring a smoother and clearer process flow for users.
    • Added a new visual status indicator that clearly shows when a runset is active, providing immediate feedback on execution status.

@prashelke
prashelke requested a review from Maheshkale447 April 10, 2025 16:25
@coderabbitai

coderabbitai Bot commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update the UI control flow during runset execution. The TestElementButtonClicked method now temporarily disables grid columns and sets the runset status to "Running" during execution before re-enabling the grid. Additionally, a new case handling the "Running" status has been added to the StatusIcon property in another mapping class, ensuring that the corresponding status icon is correctly displayed.

Changes

File(s) Change Summary
Ginger/Ginger/ApplicationModelsLib/.../POMObjectMappingWithRunsetWizardPage.xaml.cs Modified TestElementButtonClicked method: disables grid columns, updates runset status to Running, then re-enables grid columns.
Ginger/GingerCoreNET/.../MultiPomRunSetMapping.cs Added a new case in the StatusIcon property to return eImageType.Running for the Running execution status.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WizardPage
    participant Runset
    participant Grid

    User->>WizardPage: Click Test Element Button
    WizardPage->>Grid: DisableGridColumns()
    WizardPage->>Runset: Set RunSetStatus to Running
    WizardPage->>Grid: EnableGridColumns()
    WizardPage-->>User: Display updated UI
Loading

Possibly related PRs

Suggested reviewers

  • Maheshkale447

Poem

Oh, I'm a rabbit with a hop so keen,
Cheers to changes shiny and clean!
Disabling grids and setting run,
Running status now gets its fun.
With code so lively, our path's begun 🐇
Hoppity leaps and happy beams,
Celebrating code in wondrous dreams!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c778fdf and 60f99af.

📒 Files selected for processing (2)
  • Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/UpdateMultipleWizard/POMObjectMappingWithRunsetWizardPage.xaml.cs (3 hunks)
  • Ginger/GingerCoreNET/Application Models/Delta/PomDelta/MultiPomRunSetMapping.cs (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
Ginger/GingerCoreNET/Application Models/Delta/PomDelta/MultiPomRunSetMapping.cs (1) 
Learnt from: prashelke
PR: Ginger-Automation/Ginger#4150
File: Ginger/GingerCoreNET/Application Models/Delta/PomDelta/MultiPomRunSetMapping.cs:28-28
Timestamp: 2025-04-08T10:41:31.325Z
Learning: The property in MultiPomRunSetMapping class was renamed from 'runSetConfig' to 'RunSetConfig' to follow C# PascalCase naming conventions for public properties.
Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/UpdateMultipleWizard/POMObjectMappingWithRunsetWizardPage.xaml.cs (1) 
Learnt from: prashelke
PR: Ginger-Automation/Ginger#4163
File: Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/UpdateMultipleWizard/POMObjectMappingWithRunsetWizardPage.xaml.cs:198-198
Timestamp: 2025-04-08T10:41:31.325Z
Learning: prashelke prefers to keep commented-out code in the codebase when the functionality will be needed in the future, as is the case with the "Run All Run Set" toolbar tool in POMObjectMappingWithRunsetWizardPage.xaml.cs.
🧬 Code Graph Analysis (1)
Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/UpdateMultipleWizard/POMObjectMappingWithRunsetWizardPage.xaml.cs (1)
Ginger/Ginger/UserControlsLib/ucGridView/ucGrid.xaml.cs (2)
  • DisableGridColoumns (1471-1498)
  • EnableGridColumns (1442-1469)
🔇 Additional comments (4)
Ginger/GingerCoreNET/Application Models/Delta/PomDelta/MultiPomRunSetMapping.cs (1)

84-84: Added Running status support to StatusIcon switch expression

This change appropriately adds the "Running" status case to the StatusIcon property, ensuring that the UI correctly displays a running icon when the runset is executing.

Ginger/Ginger/ApplicationModelsLib/POMModels/POMWizardLib/UpdateMultipleWizard/POMObjectMappingWithRunsetWizardPage.xaml.cs (3)

230-230: UI enhancement: Disabling grid columns during execution

This change prevents user interaction with the grid while the runset is executing, which is a good practice to avoid potential state inconsistencies during processing.

271-271: Set RunSet status to Running during execution

Setting the status to "Running" before executing the runset provides clear visual feedback to users about the current state of the operation. This change works in conjunction with the StatusIcon property update in MultiPomRunSetMapping.cs.

321-321: UI enhancement: Re-enabling grid columns after execution completes

This change properly restores user interaction with the grid after execution is complete, regardless of whether execution succeeded or failed.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Maheshkale447
Maheshkale447 merged commit ee55f58 into Releases/Beta Apr 10, 2025
@Maheshkale447
Maheshkale447 deleted the BugFix/MultiPOMHungIssueFixed branch April 10, 2025 17:35
@coderabbitai coderabbitai Bot mentioned this pull request Apr 25, 2025
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maheshkale447 Maheshkale447 Maheshkale447 approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prashelke @Maheshkale447