Added Browser Arguments code for Firefox and private mode code for Edge and Firefox by rathimayur · Pull Request #4147 · Ginger-Automation/Ginger

rathimayur · 2025-03-26T16:11:14Z

Added Browser Arguments code for Firefox and private mode code for Edge and Firefox

Thank you for your contribution.
Before submitting this PR, please make sure:

Summary by CodeRabbit

New Features
- Enabled custom browser session configurations by allowing user-specified arguments.
- Activated private browsing mode for Firefox and Edge, enhancing privacy during sessions.

…ge and Firefox

coderabbitai · 2025-03-26T16:11:23Z

Walkthrough

This change updates the StartDriver method within the Selenium driver to handle additional configuration options. The method now accepts optional user arguments for Firefox, dynamically adding them to its options. Additionally, private browsing mode is enabled for Firefox by setting a specific preference and for Edge by appending an in-private argument. These modifications improve the driver’s flexibility in configuring browser sessions.

Changes

File	Change Summary
Ginger/.../Selenium/SeleniumDriver.cs	• Added a conditional block to check for non-null user arguments and add each argument to Firefox options. • Enabled private browsing for Firefox by setting a preference. • For Edge, added the "-inprivate" argument if private mode is active.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SeleniumDriver
    participant FirefoxOptions
    participant EdgeOptions

    Client->>SeleniumDriver: StartDriver()
    alt User arguments provided
        SeleniumDriver->>FirefoxOptions: For each argument, call AddArgument(arg)
    end
    alt BrowserPrivateMode is true
        SeleniumDriver->>FirefoxOptions: Set preference "browser.privatebrowsing.autostart" to true
        SeleniumDriver->>EdgeOptions: Add "-inprivate" argument
    end
    SeleniumDriver-->>Client: Return configured driver instance

Possibly related PRs

Bug fix/39660 Web Agent Page Enhancement #3830: Modifications in the SeleniumDriver class related to browser configuration changes, including handling user arguments.
Brave Browser Agent #3716: Updates to the StartDriver method in the SeleniumDriver that incorporate handling a new browser type along with similar configuration logic.
Bug fix/40547_RemoteWebDriver Agent config page not showing #3835: Changes in the same SeleniumDriver.cs file focusing on property updates and method modifications for user argument handling and private browsing support.

Suggested reviewers

Maheshkale447

Poem

I'm a rabbit, hopping in the code,
With carrots of logic in my humble abode.
Extra arguments here, private mode there,
Browsers get a tweak with a thoughtful care.
Code leaps high with each new byte,
Celebrating changes from morning till night!
🥕🐇 Happy coding to all, with delight!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb4e509 and 5d96993.

📒 Files selected for processing (1)

Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs (2 hunks)

🔇 Additional comments (3)

Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs (3)

683-689: Looks good - Added Firefox browser arguments support.

This change correctly adds support for custom command-line arguments in Firefox. The implementation iterates through SeleniumUserArgs (if not null) and adds each argument to the FirefoxOption.

690-694: Good implementation of Firefox private browsing mode.

The code correctly implements private browsing mode for Firefox by setting the appropriate preference. The comment clearly explains that this approach doesn't preserve history of the ongoing session.

837-840: Proper implementation of Edge private browsing mode.

The code correctly adds the "-inprivate" argument to Edge browser options when BrowserPrivateMode is enabled. This implementation properly aligns with how private browsing is enabled in Edge.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ser-and--Add-Browser-Arguments

Added Browser Arguments code for Firefox and private mode code for Ed…

5d96993

…ge and Firefox

coderabbitai Bot approved these changes Mar 26, 2025

View reviewed changes

rathimayur requested a review from Maheshkale447 March 27, 2025 04:50

Merge branch 'master' into BugFix-Enable-Private-Mode-in-Firefox-Brow…

c6363af

…ser-and--Add-Browser-Arguments

Maheshkale447 approved these changes Mar 28, 2025

View reviewed changes

Maheshkale447 merged commit 87640ff into master Mar 28, 2025

Maheshkale447 deleted the BugFix-Enable-Private-Mode-in-Firefox-Browser-and--Add-Browser-Arguments branch March 28, 2025 13:02

coderabbitai Bot mentioned this pull request Sep 3, 2025

Bugfix/Headless Execution Default Size #4292

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added Browser Arguments code for Firefox and private mode code for Edge and Firefox#4147

Added Browser Arguments code for Firefox and private mode code for Edge and Firefox#4147
Maheshkale447 merged 2 commits into
masterfrom
BugFix-Enable-Private-Mode-in-Firefox-Browser-and--Add-Browser-Arguments

rathimayur commented Mar 26, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 26, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rathimayur commented Mar 26, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rathimayur commented Mar 26, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)