Reviewing files that changed from the base of the PR and between bce6ba7 and bbbbe24.

• Ginger/GingerCoreCommon/ReporterLib/Reporter.cs (5 hunks)
• Ginger/GingerCoreCommon/ReporterLib/WorkSpaceReporterBase.cs (3 hunks)
• Ginger/GingerCoreCommon/UIElement/ProgressNotifier.cs (1 hunks)
• Ginger/GingerCoreNET/RunLib/CLILib/CLIHelper.cs (4 hunks)

Ginger/GingerCoreNET/RunLib/CLILib/CLIHelper.cs (1)

607-610: Reconsider skipping progress updates when progress is 0.

The current condition skips progress reporting when progress == 0, but this might hide valid initial progress updates from the user.

- if (progressInformer==null|| progress == 0)
+ if (progressInformer==null)
 {
     return;
 }

Ginger/GingerCoreCommon/ReporterLib/WorkSpaceReporterBase.cs (2)

19-19: Good addition of UIElement namespace.

The import of the UIElement namespace is properly added to support the new ProgressStatus class.

---

36-36: Method signature properly updated to use ProgressStatus.

The signature change from boolean parameter to ProgressStatus object improves the API by providing a more structured way to report progress.

Ginger/GingerCoreCommon/ReporterLib/Reporter.cs (2)

41-41: Method signature properly updated to use ProgressStatus.

The signature change from boolean parameter to ProgressStatus object aligns with the changes in WorkSpaceReporterBase.

---

328-328: Method signature properly updated to use ProgressStatus.

The signature change from boolean parameter to ProgressStatus object improves the API consistency with the rest of the application.

Reviewing files that changed from the base of the PR and between bbbbe24 and f7b3a0a.

• Ginger/GingerCoreCommon/ReporterLib/Reporter.cs (5 hunks)
• Ginger/GingerCoreCommon/ReporterLib/WorkSpaceReporterBase.cs (3 hunks)
• Ginger/GingerCoreCommon/UIElement/ProgressNotifier.cs (2 hunks)
• Ginger/GingerCoreNET/RunLib/CLILib/CLIHelper.cs (4 hunks)
• Ginger/GingerCoreNET/SourceControl/GITSourceControl.cs (3 hunks)

Ginger/GingerCoreNET/SourceControl/GITSourceControl.cs (1)

1439-1439: Reset the field when starting new operations.

previousPercentage always starts at 0. If this same instance is reused for multiple downloads or fetch operations, consider re-initializing it to 0 before each new operation to prevent leftover state issues.

Ginger/GingerCoreCommon/UIElement/ProgressNotifier.cs (1)

26-26: Parameter tuple enhances clarity.

Exposing the progress parameters as a tuple in StatusUpdateHandler is a clean approach. Ensure that each subscriber handles them correctly to avoid confusion about which value is which.

Ginger/GingerCoreNET/RunLib/CLILib/CLIHelper.cs (3)

82-82: Adding a dedicated ProgressStatus field.

Introducing progressStatus at the class level is helpful. Confirm that it’s appropriately reset to avoid stale data when reusing the same instance of CLIHelper.

---

569-571: Wire up event and instantiate progressStatus.

Attaching StatusUpdateHandler here ensures the ProgressNotifier_ProgressUpdated is invoked. This is good practice for centralized logic. Confirm that detachment in finally consistently happens in all code paths.

---

588-588: Nullify progressStatus after operation.

Clearing progressStatus is a good cleanup step. Ensure no other references to it exist or rely on it after this point.

Ginger/GingerCoreCommon/ReporterLib/Reporter.cs (3)

24-24: New import for ProgressStatus.

The added using Amdocs.Ginger.Common.UIElement; is needed to reference the ProgressStatus class. This is correct and keeps the file self-contained.

---

41-58: Potentially skip standard logging when progressInformer is not null.

You only call WorkSpaceReporter.ToLog if progressInformer is null. If the intent is to fully replace standard logs when progress is reported, that’s fine. Otherwise, consider logging both a summary and the progress updates.

---

327-341: Refactored ToConsole to accept ProgressStatus.

Allowing console output to reflect progress details is valuable. This change is consistent with the new progress-based logging approach.

Ginger/GingerCoreCommon/ReporterLib/WorkSpaceReporterBase.cs (4)

19-19: No immediate concerns identified.
This using Amdocs.Ginger.Common.UIElement; import might be necessary for features not shown in the snippet.

---

39-39: Looks good!
Using string interpolation for the log header is clean and readable.

---

75-78: Progress bar skipping when output is redirected is reasonable.
This logic avoids cluttering logs with partial progress updates in redirected output scenarios.

---

36-37:

Details

✅ Verification successful

Ensure references to the updated method signature are correct.
The signature now accepts ProgressStatus progressStatus instead of bool overwriteCurrentLine. Please verify that all calls to ToConsole throughout the codebase have been updated accordingly to avoid breakage.

You can run a repository-wide search for ToConsole( to confirm all usage sites are updated:

---

🏁 Script executed:

#!/bin/bash
# Searching for references to the updated ToConsole method
rg -A 2 -B 2 "ToConsole\("

Length of output: 10697

---

Usage of Updated ToConsole Signature Verified

The repository-wide search confirms that all calls to ToConsole now correctly use the updated method signature that accepts a ProgressStatus progressStatus parameter (defaulting to null). In particular:

• In GingerCoreCommon/ReporterLib/Reporter.cs, calls include the new parameter either through an explicit named argument (e.g., progressStatus: progressInformer) or rely on the default value.
• In GingerCoreCommon/ReporterLib/WorkSpaceReporterBase.cs, the method signature is updated as expected.
• No residual calls passing a bool overwriteCurrentLine are found.

No further modifications are needed.

Reviewing files that changed from the base of the PR and between f7b3a0a and d66fd01.

• Ginger/GingerCoreNET/SourceControl/GITSourceControl.cs (3 hunks)

Ginger/GingerCoreNET/SourceControl/GITSourceControl.cs (1)

1468-1471: Consistent progress update threshold applied.

The same threshold check has been implemented consistently in this method.

Reviewing files that changed from the base of the PR and between d66fd01 and b5b8f07.

• Ginger/GingerCoreNET/SourceControl/GITSourceControl.cs (3 hunks)

Ginger/GingerCoreNET/SourceControl/GITSourceControl.cs (6)

1398-1401: Progress reporting optimization implemented correctly.

Adding a threshold check for percentage changes avoids redundant notifications when progress hasn't changed significantly, improving UI responsiveness.

---

1404-1405: Progress tracking implementation looks good.

Updating the previousPercentage after notification ensures accurate tracking of the last reported value.

---

1440-1440: Consider using local variables instead of class fields for progress tracking.

Using a class-level field for previousPercentage could lead to issues if multiple Git operations run concurrently, as they would all share and modify the same variable.

- private double previousPercentage = 0;
+ // Remove field and use local variables in each method instead

Then, in the appropriate methods (GetProjectWithProgress and GetFetchOptionsWithProgress), add a local variable:

+ double previousPercentage = 0;

This change avoids potential race conditions and keeps progress tracking isolated to each operation.

---

1462-1462: Remove unnecessary blank line.

This blank line doesn't serve any purpose and can be removed for better code consistency.

- 

---

1469-1472: Consistent threshold check implementation.

The same optimization pattern is correctly applied here, maintaining consistency across similar operations.

---

1475-1476: Progress tracking update is properly implemented.

Storing the current percentage ensures we only report meaningful changes in future iterations.