Ginger/Ginger/Actions/ActionEditPages/ActScriptEditPage.xaml (2)

17-19: Fix naming inconsistency in control name

The change from UCFileBrowser to UCValueExpression looks good and aligns with the PR objectives. However, there's a naming inconsistency in the control name:

• 'InterPreter' should be 'Interpreter' to maintain consistent capitalization

-                    <Actions:UCValueExpression x:Name="xVScriptInterPreter"  ToolTip="Select Interpreter according to script." Width="370"/>
+                    <Actions:UCValueExpression x:Name="xVScriptInterpreter"  ToolTip="Select Interpreter according to script." Width="370"/>

---

18-18: Enhance tooltip message clarity

The current tooltip message could be more descriptive to better guide users.

-                    <Actions:UCValueExpression x:Name="xVScriptInterPreter"  ToolTip="Select Interpreter according to script." Width="370"/>
+                    <Actions:UCValueExpression x:Name="xVScriptInterPreter"  ToolTip="Select the script interpreter path or provide a value expression" Width="370"/>

Ginger/GingerCoreNET/ActionsLib/ActScript.cs (2)

86-103: LGTM! Consider adding null handling.

The property implementation correctly implements change notification. However, consider adding null handling to prevent potential null reference issues.

 public string ScriptInterpreter
 {
     get
     {
         return mScriptInterpreter;
     }
     set
     {
-        if (mScriptInterpreter != value)
+        if (!string.Equals(mScriptInterpreter, value))
         {
             mScriptInterpreter = value;
             OnPropertyChanged(nameof(ScriptInterpreter));
         }
     }
 }

---

205-207: Improve consistency in null handling and path conversion.

The null checks and path conversion handling should be consistent throughout the code.

-if (!string.IsNullOrEmpty(calculatedScriptInterpreter))
+if (string.IsNullOrEmpty(calculatedScriptInterpreter))
+{
+    Error = "Script interpreter path cannot be empty";
+    return;
+}
+try
 {
     p.StartInfo.FileName = WorkSpace.Instance.Solution.SolutionOperations.ConvertSolutionRelativePath(calculatedScriptInterpreter);
 }
+catch (Exception ex)
+{
+    Error = $"Failed to convert interpreter path: {ex.Message}";
+    return;
+}

-else if (calculatedScriptInterpreter != null && calculatedScriptInterpreter.Contains("cmd.exe"))
+else if (calculatedScriptInterpreter.Contains("cmd.exe"))

Also applies to: 259-264

Ginger/Ginger/Actions/ActionEditPages/ActScriptEditPage.xaml.cs (1)

57-57: Correct the variable name to fix inconsistent capitalization

The variable xVScriptInterPreter has inconsistent capitalization of 'Interpreter'. For consistency and readability, it should be renamed to xVScriptInterpreter.

Apply this diff to correct the variable name:

- xVScriptInterPreter.Init(Context.GetAsContext(actScript.Context), actScript, nameof(ActScript.ScriptInterpreter), true, true, UCValueExpression.eBrowserType.File, "*.*");
+ xVScriptInterpreter.Init(Context.GetAsContext(actScript.Context), actScript, nameof(ActScript.ScriptInterpreter), true, true, UCValueExpression.eBrowserType.File, "*.*");

Configuration used: CodeRabbit UI
Review profile: CHILL