D44106_Ocatne In Run set level user Pop up Removed#3988
Conversation
WalkthroughThe changes in this pull request primarily focus on the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
Ginger/Ginger/ALM/Repository/OctaneRepository.cs (2)
172-178: Use enum or constant for "RunSet" string literal.Consider replacing the hardcoded "RunSet" string with an enum or constant to improve maintainability and prevent typos.
+ private const string RUN_SET_LEVEL = "RunSet"; ... - if (businessFlow.ALMTestSetLevel.Equals("RunSet", StringComparison.CurrentCultureIgnoreCase)) + if (businessFlow.ALMTestSetLevel.Equals(RUN_SET_LEVEL, StringComparison.CurrentCultureIgnoreCase))Also, add a null check before accessing
matchingTS.ParentIdto prevent potential NullReferenceException:if (String.IsNullOrEmpty(testPlanUploadPath)) { - testPlanUploadPath = matchingTS.ParentId; + testPlanUploadPath = matchingTS?.ParentId; }
179-201: Fix indentation in else block.The indentation in the else block is inconsistent with the rest of the code. Consider fixing the indentation to improve readability.
else { - if (matchingTS != null) - { - //ask user if want to continute - userSelec = Reporter.ToUser(eUserMsgKey.BusinessFlowAlreadyMappedToTC, businessFlow.Name, matchingTS.Name); - if (userSelec == eUserMsgSelection.Cancel) - { - return false; - } - else if (userSelec == eUserMsgSelection.No) - { - matchingTS = null; - } - else - { - if (String.IsNullOrEmpty(testPlanUploadPath)) - { - testPlanUploadPath = matchingTS.ParentId; - } - } - } + if (matchingTS != null) + { + //ask user if want to continute + userSelec = Reporter.ToUser(eUserMsgKey.BusinessFlowAlreadyMappedToTC, businessFlow.Name, matchingTS.Name); + if (userSelec == eUserMsgSelection.Cancel) + { + return false; + } + else if (userSelec == eUserMsgSelection.No) + { + matchingTS = null; + } + else + { + if (String.IsNullOrEmpty(testPlanUploadPath)) + { + testPlanUploadPath = matchingTS?.ParentId; + } + } + } }Also, fix the typo in the comment "continute" -> "continue".
2 participants
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit
New Features
Bug Fixes