Files that changed from the base of the PR and between ed13792 and a251e9c.

• Ginger/GingerCoreNET/Repository/SharedRepositoryOperations.cs (2 hunks)
• Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs (1 hunks)
• Ginger/GingerCoreNET/Telemetry/TelemetryLiteDB.cs (2 hunks)

Ginger/GingerCoreNET/Telemetry/TelemetryLiteDB.cs (3)

24-24: LGTM: Added necessary using statement

The addition of using System.Globalization; is appropriate and necessary for the changes made in the NewBsonMapper method, specifically for using DateTimeStyles.RoundtripKind.

---

Line range hint 1-324: Overall assessment: Changes look good

The modifications in this file are focused and align well with the PR objectives of fixing telemetry-related bugs. The changes to DateTime handling in the NewBsonMapper method should improve the robustness of telemetry data serialization and deserialization.

As a final note, ensure that all tests related to telemetry data handling pass successfully, particularly those involving DateTime serialization and deserialization.

---

52-52: Approve change with verification request

The simplification of DateTime deserialization using DateTime.Parse with DateTimeStyles.RoundtripKind is a good improvement. It leverages built-in parsing capabilities and automatically handles the DateTime kind based on the string format.

However, please verify that this change maintains backwards compatibility with existing stored data. Ensure that previously serialized DateTime values can still be correctly deserialized with this new implementation.

To verify backwards compatibility, please run the following script:

If the script returns any results, please review those occurrences to ensure they are not negatively impacted by this change.

✅ Verification successful

Change Verified Successfully

The update to use DateTime.Parse with DateTimeStyles.RoundtripKind in TelemetryLiteDB.cs is appropriate and does not adversely affect other parts of the codebase. This change enhances the clarity of DateTime parsing in this specific context and maintains backward compatibility with existing data.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any existing DateTime deserialization in the codebase that might be affected by this change.

# Test: Search for DateTime deserialization patterns
rg --type csharp -e 'DateTime\.Parse' -e 'DateTime\.ParseExact' -e 'Convert\.ToDateTime'

Length of output: 14341

Ginger/GingerCoreNET/Repository/SharedRepositoryOperations.cs (2)

22-22: LGTM: Telemetry import added correctly.

The new import statement for Amdocs.Ginger.Common.Telemetry is correctly placed and necessary for the added telemetry functionality.

---

63-87: Overall impact: Telemetry functionality added without breaking changes.

The new telemetry functionality has been successfully integrated into the UploadItemToRepository method without introducing any breaking changes. This addition aligns with the PR objectives of addressing telemetry-related bugs. The changes are well-contained and don't affect other parts of the file.

Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs (2)

3825-3825: Use Any with a predicate to improve performance

Instead of using driverActs.Any() followed by another Any in the nested condition, combine the conditions using a predicate to minimize enumeration:

-var driverActs = activity.Acts.Where(x => !(x is ActWithoutDriver && x.GetType() != typeof(ActAgentManipulation)) && x.Active);
-if (driverActs.Any() && 
-    (!mGingerRunner.RunInSimulationMode || 
-     (mGingerRunner.RunInSimulationMode && driverActs.Any(x => !x.SupportSimulation))))
+if (activity.Acts.Any(x => !(x is ActWithoutDriver && x.GetType() != typeof(ActAgentManipulation)) && x.Active) && 
+    (!mGingerRunner.RunInSimulationMode || 
+     (mGingerRunner.RunInSimulationMode && activity.Acts.Any(x => !x.SupportSimulation))))
{
    SetCurrentActivityAgent();
}

This reduces the number of iterations over activity.Acts.

[performance]

---

3945-3945: Ensure correct loop termination condition

The condition if (act.Status != Amdocs.Ginger.CoreNET.Execution.eRunStatus.Pending && activity.Acts.IsLastItem()) may lead to the loop exiting prematurely if the last action is not in Pending status. Verify that this logic aligns with the intended behavior, and adjust the condition if necessary.