[DefectId: 39276]Removed Target Application that exist in businessflow but not in activities of the business flow by manas-droid · Pull Request #3722 · Ginger-Automation/Ginger

manas-droid · 2024-05-24T09:24:24Z

Thank you for your contribution.
Before submitting this PR, please make sure:

…on in app-agents list

…n not used in businessflow

coderabbitai · 2024-05-24T09:24:31Z

Walkthrough

The recent changes focus on refining the handling of business flows and target applications within the Ginger automation framework. Key updates include enhanced logic for managing target applications in the BusinessFlow class, adjustments to the ActivitiesList_SelectionChanged method, and modifications to unit tests to align with these changes.

Changes

File Path	Change Summary
`...NewAutomatePage.xaml.cs`	Added logic to set `CurrentItemToSave`, call `OnTargetApplicationChanged`, and iterate through `mBusinessFlow.TargetApplications`.
`...BusinessFlow.cs`	Updated `DoActivitiesLazyLoad` to filter and remove `TargetApplications` based on distinct `TargetApplication` values from `mActivities`.
`...GingerExecutionEngine.cs`	Added import of `System.Collections`.
`...ImportItemDependaciesTests.cs`	Modified assertions in `GetBusinessFlowDependacies` method, changing count assertion from 12 to 10 and removing specific `ItemExtraInfo` assertions.

Poem

In the land of code where rabbits dwell,
Changes bloom like stories to tell.
Business flows now sleek and bright,
Target apps set just right.
Tests refined, they dance in line,
Ginger's path, a journey divine.
🌸✨🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e213411 and d52dece.

Files selected for processing (3)

Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs (2 hunks)
Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs (1 hunks)
Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs (1 hunks)

Files skipped from review due to trivial changes (1)

Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs

Additional comments not posted (2)

Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs (2)
419-419: Ensure that CurrentItemToSave is properly set to mBusinessFlow.

This change aligns with the PR's objective to ensure the current business flow is saved correctly when changes occur.

564-564: Review the invocation of OnTargetApplicationChanged.

Ensure that the method OnTargetApplicationChanged is correctly handling the removal of unused target applications as per the PR's objectives. This is crucial for maintaining consistency in the business flow's state.
Verification successful

The OnTargetApplicationChanged method is implemented as follows:
private void OnTargetApplicationChanged(object arg1, SelectionChangedEventArgs args)
{
    var selectedTargetApplication = (mActivity != null) ? WorkSpace.Instance.Solution.GetSolutionTargetApplications().FirstOrDefault((targetApp) => targetApp.Name.Equals(mActivity.TargetApplication)) as TargetApplication : null;

    if (selectedTargetApplication != null && !mBusinessFlow.TargetApplications.Any(bfTA => ((TargetApplication)bfTA).AppName.Equals(selectedTargetApplication.AppName)))
    {
        // Logic to handle the addition or removal of target applications
    }
}
The method retrieves the selected target application and checks if it exists in the business flow's target applications. If the selected target application is not found in the business flow's target applications, it implies that the method should handle the addition or removal of target applications.

The method is invoked in various contexts, such as property changes and activity list changes, ensuring that the business flow's state remains consistent.

Based on the provided implementation and context, the OnTargetApplicationChanged method appears to handle the removal of unused target applications correctly.
Scripts Executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify that `OnTargetApplicationChanged` is correctly handling the removal of unused target applications.

# Test: Search for the method implementation and usage. Expect: Proper handling of target applications.
rg --type csharp $'OnTargetApplicationChanged'
Length of output: 861

Script:
#!/bin/bash
# Extract the implementation of the OnTargetApplicationChanged method
ast-grep --lang csharp --pattern $'private void OnTargetApplicationChanged($_, $_) {
  $$$
}' --json

# Extract the context of its invocations
rg --context 5 --type csharp $'OnTargetApplicationChanged'
Length of output: 6174

coderabbitai · 2024-05-24T09:28:27Z

+
+                IEnumerable<string> distinctTargetApp =  mActivities.Select((activity) => activity.TargetApplication).Distinct();
+
+                for(int indx=0; indx < TargetApplications.Count;)
+                {
+                    if (!distinctTargetApp.Contains(TargetApplications[indx].Name))
+                    {
+                        TargetApplications.RemoveAt(indx);
+                    }
+                    else
+                    {
+                        indx++;
+                    }
+                }


Optimize the removal of TargetApplications to enhance performance.

The current implementation iterates through TargetApplications and removes items one by one, which can be inefficient with large collections. Consider using a more efficient approach, such as filtering TargetApplications directly:

TargetApplications = new ObservableList<TargetBase>(TargetApplications.Where(ta => distinctTargetApp.Contains(ta.Name)));

This approach reconstructs the TargetApplications list in a more performant manner by leveraging LINQ's internal optimizations.

MeniKadosh1

i will set a a call

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d52dece and 598a66a.

Files selected for processing (1)

Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs (3 hunks)

Files skipped from review as they are similar to previous changes (1)

Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 598a66a and 77a007e.

Files selected for processing (2)

Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs (3 hunks)
Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs (1 hunks)

Files skipped from review as they are similar to previous changes (2)

Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs
Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs

The base branch was changed.

…n/Ginger into Defect/UpdateTA

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77a007e and e01f5ce.

Files selected for processing (1)

Ginger/GingerCoreNETUnitTest/GlobalCrossSolutionTestsLib/ImportItemDependaciesTests.cs (2 hunks)

Files skipped from review due to trivial changes (1)

Ginger/GingerCoreNETUnitTest/GlobalCrossSolutionTestsLib/ImportItemDependaciesTests.cs

Manas Kalangan added 5 commits May 21, 2024 16:47

Added activities target application set in to update target applicati…

2a966ba

…on in app-agents list

Changed the bfsTargetApplications from ObservableList to HashSet

2419514

Reverted change in GingerExecutionEngine and removed targetapplicatio…

f89f4af

…n not used in businessflow

Merge branch 'Releases/Official-Release' into Defect/UpdateTA

cce0074

Shifted the code to BusinessFlow

d52dece

manas-droid requested a review from MeniKadosh1 May 24, 2024 09:27

manas-droid changed the title ~~Removed Target Application that exist in businessflow but not in activities of the business flow~~ [DefectId: 39276]Removed Target Application that exist in businessflow but not in activities of the business flow May 24, 2024

coderabbitai Bot reviewed May 24, 2024

View reviewed changes

MeniKadosh1 reviewed May 26, 2024

View reviewed changes

Comment thread Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs

MeniKadosh1 reviewed May 26, 2024

View reviewed changes

Renamed agents to target applications

598a66a

coderabbitai Bot reviewed May 27, 2024

View reviewed changes

MeniKadosh1 reviewed May 27, 2024

View reviewed changes

Comment thread Ginger/Ginger/AutomatePageLib/NewAutomatePage.xaml.cs Outdated

MeniKadosh1 reviewed May 27, 2024

View reviewed changes

Comment thread Ginger/GingerCoreNET/Run/GingerExecutionEngine.cs Outdated

Implemented the PR comments

77a007e

coderabbitai Bot reviewed May 27, 2024

View reviewed changes

MeniKadosh1 previously approved these changes May 29, 2024

View reviewed changes

manas-droid changed the base branch from Releases/Official-Release to master May 29, 2024 07:10

MeniKadosh1 approved these changes May 29, 2024

View reviewed changes

MeniKadosh1 and others added 2 commits May 29, 2024 10:10

Merge branch 'master' into Defect/UpdateTA

1b22e92

Merge branch 'master' into Defect/UpdateTA

26a6617

MeniKadosh1 previously approved these changes May 29, 2024

View reviewed changes

Manas Kalangan added 2 commits May 30, 2024 14:51

Updated Unit Test after the unused Target Applications are deleted

c4deb85

Merge branch 'Defect/UpdateTA' of https://github.com/Ginger-Automatio…

e01f5ce

…n/Ginger into Defect/UpdateTA

manas-droid dismissed MeniKadosh1’s stale review via e01f5ce May 30, 2024 09:27

coderabbitai Bot reviewed May 30, 2024

View reviewed changes

manas-droid requested a review from MeniKadosh1 May 30, 2024 10:28

MeniKadosh1 approved these changes May 30, 2024

View reviewed changes

manas-droid merged commit e3e24f4 into master May 30, 2024

manas-droid deleted the Defect/UpdateTA branch May 30, 2024 11:34

coderabbitai Bot mentioned this pull request Jan 6, 2025

Feature/Business flow/ Runset and shared activity open #4049

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DefectId: 39276]Removed Target Application that exist in businessflow but not in activities of the business flow#3722

[DefectId: 39276]Removed Target Application that exist in businessflow but not in activities of the business flow#3722
manas-droid merged 11 commits into
masterfrom
Defect/UpdateTA

manas-droid commented May 24, 2024

Uh oh!

coderabbitai Bot commented May 24, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot May 24, 2024

Uh oh!

Uh oh!

MeniKadosh1 left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

manas-droid commented May 24, 2024

Uh oh!

coderabbitai Bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot May 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MeniKadosh1 left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented May 24, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)