BugFix - 39087 - No Popup When Switching From Dirty Runset#3648
Merged
IamHarsimranjeet merged 5 commits intoMay 2, 2024
Merged
Conversation
…er then, when we switch from one dirty runset to another, we don't get a popup to save the dirty runset before switching. RC: When we move from one runset to another, we check if the previous runset was the part of the same solution or not. To do this check we rely solution folder and solution name which can be different is some cases. Fix: Instead of relying on the solution folder and name, we can check if the current solution have a runset with the id of the previous runset or not. If yes then the previous runset was part of the current solution otherwise not.
Contributor
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…pWhenSwitchingVirtualRunset
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Maheshkale447
approved these changes
Apr 30, 2024
…pWhenSwitchingVirtualRunset
…pWhenSwitchingVirtualRunset
…pWhenSwitchingVirtualRunset
IamHarsimranjeet
deleted the
BugFix/39087-NoSavePopupWhenSwitchingVirtualRunset
branch
May 2, 2024 09:01
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution.
Before submitting this PR, please make sure: