Skip to content

Update vscode-textmate-languageservice from 0.1.1 to 0.2.0#150

Merged
Gimly merged 10 commits intomasterfrom
unknown repository
Dec 13, 2021
Merged

Update vscode-textmate-languageservice from 0.1.1 to 0.2.0#150
Gimly merged 10 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 2, 2021

Closes #140, closes #141, closes #142, closes #143, closes #145, closes #147.

Changelog:

  • Update grammar with extended function definition syntax and superclass method @ operator.
  • Update Textmate service API with optimisations, bugfixes and Atom's Textmate scope parser.

Tasks:

N.B: Major change - meta.parens does not match meta.function-call.parens in Textmate scope selectors.

@ghost ghost marked this pull request as draft December 2, 2021 22:43
@ghost ghost marked this pull request as ready for review December 2, 2021 23:52
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 13, 2021

@Gimly could this go out before New Year?

@Gimly
Copy link
Copy Markdown
Owner

Gimly commented Dec 13, 2021

Could you please update the CHANGELOG.md at the root of the repository with the changes you did?

I'll then merge and try to push a new version today.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 13, 2021

Done, is esbuild working now that we have no WASM and native dependencies?
I am running this PR on my side and its a beautifully smooth experience

@Gimly
Copy link
Copy Markdown
Owner

Gimly commented Dec 13, 2021

I think it should, but haven't had the time to do further testing, we'll see how it goes.

@Gimly Gimly merged commit 4018ad3 into Gimly:master Dec 13, 2021
@ghost ghost deleted the feat-service-upgrade branch December 13, 2021 12:36
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 13, 2021

#151 should be good for release in 1.3.0 also. Will research making this run in the browser too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant