Skip to content

Conversation

@Gilnaa
Copy link
Owner

@Gilnaa Gilnaa commented Nov 7, 2019

Tested with nightly-2017-09-01 which was just after 1.20 was released.

The 1.40 version comparison currently doesn't work, since the nightly 1.40 compiler equates lower than Version::from((1, 40, 0)). This shouldn't be a problem once 1.41 nightly compilers are available.

@Gilnaa Gilnaa merged commit 349f7d0 into master Nov 7, 2019
@Gilnaa Gilnaa mentioned this pull request Nov 7, 2019
@RalfJung
Copy link
Collaborator

RalfJung commented Nov 7, 2019

the nightly 1.40 compiler equates lower than Version::from((1, 40, 0))

That seems like a bug?

@Gilnaa
Copy link
Owner Author

Gilnaa commented Nov 7, 2019

I don't think so, 1.40-nightly does predate 1.40-stable.
I'm okay with this situation since not all 1.40 nightlies support doctest and 1.41 should be out any minute now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants