This repository was archived by the owner on Dec 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
This repository was archived by the owner on Dec 5, 2021. It is now read-only.
Refactoring #35
Copy link
Copy link
Open
Labels
EnhancementNew feature or requestNew feature or requestIn ProcessThis issue work in processThis issue work in processdependenciesPull requests that update a dependency filePull requests that update a dependency filev4 goal
Milestone
Description
Needs heavily refactoring
-
be SOLID
- Single Responsibility Principle
- Open Closed Principle
- Liskov Substitution Principle
- Interface Segregation Principle
- Dependency Inversion Principle
-
remove cyclic dependencies ( MsgUtil is depending on Util and the other way around, same for DatabaseHelper)
-
properly inject dependencies instead of static abuse shit
-
properly handle configurations
-
write Adapter for used functionality in libraries
-
use PreparedStatement in the right way
-
cache data instead of writing each time -> persist every N minutes
-
encapsulate the classes to reduce complexity
-
cleanup commands, introduce a subcommand system
-
use Player#hasPermission instead of using an explicit PermissionProvider that is already injected into Bukkit system
-
remove duplication of ServerNMS and ItemNMS
-
refactor MsgUtil
- reduce code duplication
- apply SRP
-
write javadoc for plugin
-
Remove classes that are not used anymore
-
refactor shop loader
Metadata
Metadata
Labels
EnhancementNew feature or requestNew feature or requestIn ProcessThis issue work in processThis issue work in processdependenciesPull requests that update a dependency filePull requests that update a dependency filev4 goal