Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

Refactoring #35

@yannicklamprecht

Description

@yannicklamprecht

Needs heavily refactoring

  • be SOLID

    • Single Responsibility Principle
    • Open Closed Principle
    • Liskov Substitution Principle
    • Interface Segregation Principle
    • Dependency Inversion Principle
  • remove cyclic dependencies ( MsgUtil is depending on Util and the other way around, same for DatabaseHelper)

  • properly inject dependencies instead of static abuse shit

  • properly handle configurations

  • write Adapter for used functionality in libraries

  • use PreparedStatement in the right way

  • cache data instead of writing each time -> persist every N minutes

  • encapsulate the classes to reduce complexity

  • cleanup commands, introduce a subcommand system

  • use Player#hasPermission instead of using an explicit PermissionProvider that is already injected into Bukkit system

  • remove duplication of ServerNMS and ItemNMS

  • refactor MsgUtil

    • reduce code duplication
    • apply SRP
  • write javadoc for plugin

  • Remove classes that are not used anymore

  • refactor shop loader

Metadata

Metadata

Labels

EnhancementNew feature or requestIn ProcessThis issue work in processdependenciesPull requests that update a dependency filev4 goal

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions