Removed hardcoded navigator#103
Merged
skydoves merged 2 commits intoGetStream:mainfrom Oct 20, 2023
AndroidPoet:removed_hardcoded_navigator
Merged
Removed hardcoded navigator#103skydoves merged 2 commits intoGetStream:mainfrom AndroidPoet:removed_hardcoded_navigator
skydoves merged 2 commits intoGetStream:mainfrom
AndroidPoet:removed_hardcoded_navigator
Conversation
Contributor
Author
|
Hi @skydoves Thanks, |
skydoves
approved these changes
Oct 20, 2023
Contributor
skydoves
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
The goal of this pull request is to restructure the code by moving the Compose Navigator to a ViewModel. This change is being made to make Composables independent of concrete dependencies, thereby improving scalability. This pull request addresses the need for a more modular and maintainable architecture in the codebase.
🛠 Implementation details
Describe the implementation details for this Pull Request.
In this pull request, the implementation details involve reorganizing the code to separate the Compose Navigator from concrete dependencies and placing it within a ViewModel. This change allows for greater flexibility and independence of Composables. It involves moving relevant functions, dependencies, and logic into the ViewModel. The Composables can now interact with the ViewModel instead of concrete dependencies.
✍️ Explain examples
Explain examples with code for this updates.
Preparing a pull request for review
Ensure your change is properly formatted by running:
I have run the provided formatting command to ensure the changes are correctly formatted:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.