Skip to content

Comments

Use workflows from build conventions repository#1589

Merged
gpunto merged 2 commits intodevelopfrom
and-961/move-workflows
Dec 24, 2025
Merged

Use workflows from build conventions repository#1589
gpunto merged 2 commits intodevelopfrom
and-961/move-workflows

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Dec 23, 2025 •
edited by coderabbitai bot
Loading

Goal

AND-961: Move shared workflows to conventions repo

We're centralizing the workflows with the plugins in the build conventions repo, so we're changing the references to point to them

Implementation

Change the workflow references

🎨 UI Changes

None

Testing

The workflows should run

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs
  • Check the SDK Size Comparison table in the CI logs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows to use new build conventions.
    • Added concurrency configuration to optimize pull request workflow execution.

✏️ Tip: You can customize this high-level summary in your review settings.

@gpunto gpunto added the pr:ci CI / GitHub Actions / workflow updates label Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025 •
edited
Loading

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.94 MB 11.94 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@gpunto gpunto marked this pull request as ready for review December 24, 2025 08:25
@gpunto gpunto requested a review from a team as a code owner December 24, 2025 08:25
@gpunto gpunto enabled auto-merge (squash) December 24, 2025 08:25
@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025

Walkthrough

This pull request migrates two GitHub Actions workflows from the android-ci-actions repository to the stream-build-conventions-android repository, updating references and pinning to a specific version (v0.6.0). One workflow also introduces concurrency configuration to manage job cancellation.

Changes

Cohort / File(s) Summary
Workflow Reference Migration
.github/workflows/pr-clean-old-drafts.yaml		 Job name updated from pr-checklist to pr-clean-stale. Workflow reference changed from GetStream/android-ci-actions@main to GetStream/[email protected]. Schedule comment updated.
Workflow Reference Migration & Configuration
.github/workflows/pr-quality.yml		 Workflow reference updated from GetStream/android-ci-actions@main to GetStream/[email protected]. Concurrency group added with cancel-in-progress enabled. Minor formatting applied to PR event types array.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Our workflows now hop to conventions new,
From actions old to a cleaner view,
With versions pinned and concurrency set,
The best workflow migration yet! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: moving workflow references to the build conventions repository.
Description check ✅ Passed The description follows the template with goal, implementation, and testing sections properly filled, though some checklist items lack evidence of completion.
Linked Issues check ✅ Passed The PR updates workflow references to point to the build conventions repository, aligning with AND-961's objective to centralize workflows.
Out of Scope Changes check ✅ Passed All changes are scoped to workflow file updates in .github/workflows/ directory, directly related to moving shared workflows to the conventions repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch and-961/move-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Dec 24, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 866bfc9 and 82373b4.

📒 Files selected for processing (2)
  • .github/workflows/pr-clean-old-drafts.yaml
  • .github/workflows/pr-quality.yml
🔇 Additional comments (4)
.github/workflows/pr-clean-old-drafts.yaml (2)

6-6: LGTM: Cron schedule is correctly configured.

The cron expression "0 7 * * 1" correctly schedules the workflow to run every Monday at 07:00 UTC. The comment accurately reflects the timing.

15-16: The workflow reference is correct and properly configured.

The migration to the centralized conventions repository is valid. The pr-clean-stale.yaml workflow exists at v0.6.0 in the GetStream/stream-build-conventions-android repository, and the job name change from pr-checklist to pr-clean-stale aligns with the new workflow name.

.github/workflows/pr-quality.yml (2)

5-5: LGTM: Formatting change improves readability.

The addition of spaces in the array is a minor formatting improvement that enhances readability.

12-14: Excellent addition: Concurrency configuration prevents redundant workflow runs.

The concurrency configuration will automatically cancel in-progress workflow runs when new commits are pushed to the same PR, which saves CI resources and reduces wait times.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gpunto gpunto merged commit 01b3abc into develop Dec 24, 2025
11 checks passed
@gpunto gpunto deleted the and-961/move-workflows branch December 24, 2025 09:27
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2025
Merged
21 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
Merged
21 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

pr:ci CI / GitHub Actions / workflow updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gpunto @aleksandar-apostolov