[AND-956] Fix an issue where Android SDK may end up in a reconnect loop#1584
Merged
aleksandar-apostolov merged 3 commits intodevelopfrom Dec 16, 2025
Merged
[AND-956] Fix an issue where Android SDK may end up in a reconnect loop#1584aleksandar-apostolov merged 3 commits intodevelopfrom
aleksandar-apostolov merged 3 commits intodevelopfrom
Conversation
aleksandar-apostolov
changed the title
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
aleksandar-apostolov
changed the title
PratimMallick
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
AND-956
Fix an issue where Android SDK may end up in a reconnect loop.
Implementation
Do not create the publisher peer connection if there is no capability to publish anything. The reason for this is that in certain scenario when fast reconnecting the publisher will send an empty
SetPublisherwhich will be rejected pushing the SDK into a loop of reconnects. To avoid this we simply do not initialize the publisher if we do not have capability to publish.Testing
Run unit tests. Do smoke test and sanity checks.