Improve RtcSession Creation Logic: Handle Errors Gracefully#1576
Merged
aleksandar-apostolov merged 4 commits intodevelopfrom Nov 28, 2025
Merged
Improve RtcSession Creation Logic: Handle Errors Gracefully#1576aleksandar-apostolov merged 4 commits intodevelopfrom
aleksandar-apostolov merged 4 commits intodevelopfrom
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
rahul-lohra
changed the title
rahul-lohra
added
pr:bug
rahul-lohra
changed the title
Contributor
PratimMallick
left a comment
PratimMallick
left a comment
There was a problem hiding this comment.
Should we also take this opportunity to move the creation of RTCSession logic to one place/method rather than have it at 3 places . Easier readability and less lines
Contributor
|
Refactoring the call / state / RTCSession is part of another topic, lets just fix this here. |
aleksandar-apostolov
approved these changes
Nov 27, 2025
|
aleksandar-apostolov
deleted the
bugfix/rahullohra/call-cleanup-crash
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Improve RtcSession Creation Logic: Handle Errors Gracefully
Implementation
Wrap
RtcSessioninstace creation inside try-catchTesting
To reproduce the error follow the steps
call.cleanup()on the first line insidecall.join()