Skip to content

Comments

Added support for High fidelity (hi-fi) audio capture#1564

Merged
aleksandar-apostolov merged 35 commits intodevelopfrom
hifi_audio
Nov 7, 2025
Merged

Added support for High fidelity (hi-fi) audio capture#1564
aleksandar-apostolov merged 35 commits intodevelopfrom
hifi_audio

Conversation

@PratimMallick
Copy link
Contributor

@PratimMallick PratimMallick commented Nov 4, 2025 •
edited
Loading

Goal

This PR adds support for HiFi (high-fidelity) audio in the Stream Video Android SDK, enabling users to choose a certain type of audio profile before joining the call.
This enhancement allows applications to provide better audio quality for music streaming, podcast calls, or any scenario requiring higher audio fidelity

Implementation

  1. Audio Bitrate Profile Support (MediaManager.kt):

    • Added audioBitrateProfile StateFlow in MicrophoneManager to track current audio profile
    • Implemented setAudioBitrateProfile() method that validates:
      • HiFi audio must be enabled in dashboard settings to use MUSIC_HIGH_QUALITY
      • Profile can only be changed before joining a call
    • Added AudioBitrateProfile enum support with VOICE_STANDARD_UNSPECIFIED and MUSIC_HIGH_QUALITY options

  2. Peer Connection Factory Refactoring (StreamPeerConnectionFactory.kt):

    • Refactored factory creation to accept audioBitrateProfileProvider function, which enables it to turn off hardware AEC, NS
    • Factory is recreated when audio profile changes (before joining)

  3. Call State Management (Call.kt):

  • Added ensureFactoryMatchesAudioProfile() to validate factory matches current profile
  • Implemented recreateFactoryAndAudioTracks() to rebuild factory and tracks. This is needed if app has to provide a toggle in Lobby screen, where intial factory is already created with the default audioProfile
  • Made video/audio tracks and sources nullable and lazy-initialized for proper recreation
  • Shared EGL base context between factory and media manager to break circular dependency

  1. UI Components (ToggleHifiAudioAction.kt):

    • New composable action button for toggling HiFi audio
    • Integrates with CallAction system via ToggleHifiAudio action
    • Provides visual feedback with music note icons (MusicNote/MusicOff)

  2. Demo App Integration:

    • Added HiFi audio toggle in CallLobbyScreen and CallScreen

🎨 UI Changes

Screenshot_20251105_122805

Testing

  1. HiFi Audio Toggle:
    • Start a call from the demo app
    • Use the music note icon button in call controls to toggle HiFi audio
    • Verify that the publishing bitrate of audio is 128 kbps,
    • Verify that remote audio is looped back and sent again creating an echo which denotes that AEC is turned off
    • If you can, then play an instrument of your choice and observe the quality on the other side. The high notes should not be cut off denoting , both NS and AGC are turned off

PratimMallick and others added 19 commits October 16, 2025 09:33
@PratimMallick
Update to latest proto
383e41d
@PratimMallick
Send stereo = true in Audio track's TrackInfo if hifi is enabled in d…
8a48b85 
…ashboard
@PratimMallick
fix: microphone not getting enabled if we join with USAGE_MEDIA mode
f5d513f
@PratimMallick
Merge branch 'develop' of github.com:GetStream/stream-video-android i…
576f342 
…nto hifi_audio
@PratimMallick
Provide a way to set the audio usage from app to call.speaker - it ca…
379ee0f 
…n be either VOICE_COMMUNICATION or MEDIA
@PratimMallick
Provide a way on the debug option menu to switch between usage_media …
ed1a969 
…and usage_voice_communication
@PratimMallick
Expose the audioDeviceModule from peerConnectionFactory
1ef32b9
@PratimMallick
Apply spotless
16e8e8a
@PratimMallick
Upgraded to webrtc version that supports switching audio usage mid call
2ddc7b7
@PratimMallick
api dump
a8690a8
@PratimMallick
Merge branch 'develop' of github.com:GetStream/stream-video-android i…
e6b9abd 
…nto hifi_audio
@PratimMallick
Dont send stereo = true in trackInfo while publishing. This will be d…
503c9d7 
…one when adding stereo capture to recording feature
@PratimMallick
Added unit tests to test the audioUsage stateFlow of SpeakerManager
bbbbf2b
@aleksandar-apostolov
Merge branch 'develop' into hifi_audio
ace13ef
@aleksandar-apostolov
Merge branch 'develop' into hifi_audio
789ad8b
@PratimMallick
refactor(demo-app): simplify onToggleAudioUsage by removing suspend m…
57bba73 
…odifier
@PratimMallick
Merge remote-tracking branch 'origin/hifi_audio' into hifi_audio
b755b0a
@PratimMallick
Fix: setAudioUsage of speakerManager does not work if called before…
f96d3ec 
… any remote track has come in. Updated to webrtc which has the fix for this.
@PratimMallick
Added : Enable Hifi audio recording
accddc9
@PratimMallick PratimMallick requested a review from a team as a code owner November 4, 2025 13:49
@PratimMallick PratimMallick marked this pull request as draft November 4, 2025 13:50
@PratimMallick
Merge branch 'develop' of github.com:GetStream/stream-video-android i…
b52e65b 
…nto hifi_audio

# Conflicts:
#	stream-video-android-core/api/stream-video-android-core.api
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/MediaManager.kt
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/connection/StreamPeerConnectionFactory.kt
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.91 MB 11.91 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.25 MB 6.25 MB 0.00 MB 🟢

@PratimMallick
Make setters for audio,video and screenshare tracks so that they dont…
de3d61f 
… come under breaking change

Make eglbase optional param while creating StreamPeerConnectionFctory so that it doesnt come under breaking change
@PratimMallick PratimMallick changed the title hifi_audio Added support for High fidelity (hi-fi) audio capture Nov 5, 2025
@PratimMallick PratimMallick added the pr:new-feature Adds new functionality label Nov 5, 2025
@PratimMallick PratimMallick marked this pull request as ready for review November 5, 2025 07:00
PratimMallick and others added 11 commits November 5, 2025 13:53
@PratimMallick
Fix: have a setter to peerConnectionFactory so that it can be accesse…
6fd8c65 
…d from uit tests
@PratimMallick
Fix: unit test setup for StreamPeerConnectionFactoryTest
c95536d
@PratimMallick
Changed StreamPeerConnectionFactory to use a provider function for Eg…
d814890 
…lBase instead of a direct parameter. So that unit test can initiaze StreamPeerConnectionFactory without invoking EglBase.create() in the constructor
@PratimMallick
Make adm private to StreamPeerConnectionFactory
4a9dbf4
@PratimMallick
api dump
52f4bd7
@PratimMallick
Fix tests not running locally
d5b3ae5
@PratimMallick
Fix: Publish unit tests need to mock the value of mediaManager.microp…
4b50712 
…hone.audioBitrateProfile
@aleksandar-apostolov
Merge branch 'develop' into hifi_audio
8574cf8
@PratimMallick
1. make setAudioBitrateProfile a suspend method so that it can fetch …
81faabb 
…the call settings before setting the profile in the call

2. Lobby does not show the hifi toggle button if it is not enables in the call settings
@PratimMallick
Merge remote-tracking branch 'origin/hifi_audio' into hifi_audio
b81c055
@aleksandar-apostolov
Merge branch 'develop' into hifi_audio
e2f4343
rahul-lohra
rahul-lohra reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@rahul-lohra rahul-lohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
12.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

rahul-lohra
rahul-lohra approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@rahul-lohra rahul-lohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aleksandar-apostolov aleksandar-apostolov merged commit 38bdaad into develop Nov 7, 2025
11 of 12 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the hifi_audio branch November 7, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul-lohra rahul-lohra rahul-lohra approved these changes

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees

No one assigned

Labels

pr:new-feature Adds new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PratimMallick @rahul-lohra @aleksandar-apostolov