Skip to content

Comments

Fix quoting edited messages showing outdated text#6107

Merged
VelikovPetar merged 3 commits intodevelopfrom
bug/fix_quoting_edited_messages
Jan 26, 2026
Merged

Fix quoting edited messages showing outdated text#6107
VelikovPetar merged 3 commits intodevelopfrom
bug/fix_quoting_edited_messages

Conversation

@VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Jan 26, 2026 •
edited by coderabbitai bot
Loading

🎯 Goal

Quoting an edited message (in the current session) results in the quoted content showing and outdated version of the message.
Resolves: https://linear.app/stream/issue/AND-1032

🛠 Implementation details

Remember the Message to ensure updated values are captured in the onReply lambda

🎨 UI Changes

Before After
before.mp4
after.mp4

🧪 Testing

  1. Open compose sample
  2. Edit a message
  3. Quote the message
  4. The quoted content (shown in the composer) should show the edited message

Summary by CodeRabbit

  • Bug Fixes
    • Fixed quoting edited messages to display the current message text instead of outdated content.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.26 MB 5.26 MB 0.00 MB 🟢
stream-chat-android-offline 5.48 MB 5.48 MB 0.00 MB 🟢
stream-chat-android-ui-components 10.63 MB 10.63 MB 0.00 MB 🟢
stream-chat-android-compose 12.84 MB 12.84 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review January 26, 2026 17:11
@VelikovPetar VelikovPetar requested a review from a team as a code owner January 26, 2026 17:11
@VelikovPetar VelikovPetar enabled auto-merge (squash) January 26, 2026 19:51
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

A bug fix for message quoting that captures the current message state using rememberUpdatedState to prevent stale message data from being passed to the reply callback when messages are edited.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md		 Added changelog entry documenting the fix for quoted messages showing outdated text
State Capture Fix
stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageItem.kt		 Added rememberUpdatedState import and implemented state capture for replyMessage to ensure the onReply callback in SwipeToReply references the current message value instead of a potentially stale closure

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A message once quoted, now fresh as spring dew,
No staleness lingers when edits break through,
With remembered state keeping replies so true,
The chat flows like carrots—forever brand new! 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely summarizes the main bug fix: preventing outdated message text when quoting edited messages.
Description check ✅ Passed The PR description includes the goal, implementation details, UI changes with before/after videos, and testing steps. However, it is missing the contributor checklist section.
Linked Issues check ✅ Passed The code changes directly address the linked issue AND-1032 by using rememberUpdatedState to capture the latest message value in the onReply lambda, ensuring edited messages are quoted with current text.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the quoting of edited messages: CHANGELOG.md entry added and MessageItem.kt modified to remember updated message state for the onReply callback.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 26, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VelikovPetar VelikovPetar merged commit d0ba147 into develop Jan 26, 2026
14 checks passed
@VelikovPetar VelikovPetar deleted the bug/fix_quoting_edited_messages branch January 26, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpunto gpunto gpunto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VelikovPetar @gpunto