Skip to content

Comments

Use workflows from build conventions repository#6060

Merged
VelikovPetar merged 1 commit intodevelopfrom
and-961/move-workflows
Dec 24, 2025
Merged

Use workflows from build conventions repository#6060
VelikovPetar merged 1 commit intodevelopfrom
and-961/move-workflows

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Dec 24, 2025 •
edited by coderabbitai bot
Loading

🎯 Goal

AND-961: Move shared workflows to conventions repo

We're centralizing the workflows with the plugins in the build conventions repo, so we're changing the references to point to them

🛠 Implementation details

Change the workflow references

🎨 UI Changes

None

🧪 Testing

The workflows should run correctly

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs
  • Check the SDK Size Comparison table in the CI logs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configurations to use the latest build conventions and improved permissions handling for pull request management processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.25 MB 0.00 MB 🟢
stream-chat-android-offline 5.48 MB 5.48 MB 0.00 MB 🟢
stream-chat-android-ui-components 10.60 MB 10.60 MB 0.00 MB 🟢
stream-chat-android-compose 12.81 MB 12.81 MB 0.00 MB 🟢

@gpunto gpunto marked this pull request as ready for review December 24, 2025 13:59
@gpunto gpunto requested a review from a team as a code owner December 24, 2025 13:59
@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025

Walkthrough

GitHub Actions workflows are migrated from the android-ci-actions repository to the stream-build-conventions-android repository, with the PR cleanup workflow also receiving explicit permissions and a job rename. Action references are pinned to version v0.6.1.

Changes

Cohort / File(s) Summary
PR Cleanup Configuration
.github/workflows/pr-cleanup.yaml		 Added top-level permissions block granting write access to contents, pull-requests, and issues. Renamed job from pr-cleanup to pr-clean-stale. Updated workflow action source from GetStream/android-ci-actions/.github/workflows/pr-clean-stale.yaml@main to GetStream/stream-build-conventions-android/.github/workflows/[email protected].
SDK Size Workflows
.github/workflows/sdk-size-checks.yml, .github/workflows/sdk-size-updates.yml		 Updated action references for both compare-sdk-sizes and update-sdk-sizes jobs from GetStream/android-ci-actions to GetStream/stream-build-conventions-android with version pinning to v0.6.1. Inputs and secrets remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 The workflows hop to a new warren,
From android-ci to conventions so grand,
Version v0.6.1 marks the path forward,
Permissions granted, jobs now renamed with care,
Our shared tools thrive in their new home! 🌿

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the primary change: updating GitHub Actions workflow references to use the build conventions repository instead of the android-ci-actions repository.
Description check ✅ Passed The description follows the template structure with goal, implementation details, UI changes, and testing sections completed. The PR is linked to the GitHub issue AND-961 as required.
Linked Issues check ✅ Passed The PR addresses the objective to move shared workflows from android-ci-actions to the build conventions repository by updating all workflow references across three files.
Out of Scope Changes check ✅ Passed All changes are within scope: workflow references are updated to point to the build conventions repository, and a permissions block is added to pr-cleanup.yaml as needed for workflow execution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch and-961/move-workflows
📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5e4c05f and cacf274.

📒 Files selected for processing (3)
  • .github/workflows/pr-cleanup.yaml
  • .github/workflows/sdk-size-checks.yml
  • .github/workflows/sdk-size-updates.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Debug build
🔇 Additional comments (4)
.github/workflows/pr-cleanup.yaml (2)

8-11: The explicit permissions block enhances security clarity.

The added permissions block explicitly grants write access for contents, pull-requests, and issues, which are appropriate for a cleanup workflow that removes stale PRs and branches. This follows the principle of least privilege by making permissions explicit.

14-15: No breaking downstream dependencies found.

The job name change from pr-cleanup to pr-clean-stale is safe. A codebase-wide search confirms there are no internal references to the old job name, so no local dependencies will break. The new name aligns with the external workflow filename being called (pr-clean-stale.yaml), which follows good naming conventions. The change is intentional as part of delegating to the centralized build conventions repository.

.github/workflows/sdk-size-updates.yml (1)

16-16: The workflow file exists and is accessible at version v0.6.1 in the GetStream/stream-build-conventions-android repository. No further action needed.

.github/workflows/sdk-size-checks.yml (1)

12-12: Workflow verified to exist at v0.6.1. The repository GetStream/stream-build-conventions-android, tag v0.6.1, and workflow file .github/workflows/sdk-size-checks.yml are all accessible. The workflow defines the expected inputs and secrets, confirming interface compatibility.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@VelikovPetar VelikovPetar merged commit d6a612b into develop Dec 24, 2025
12 checks passed
@VelikovPetar VelikovPetar deleted the and-961/move-workflows branch December 24, 2025 15:14
gpunto added a commit that referenced this pull request Dec 29, 2025
@gpunto
Use workflows from build conventions repository (#6060)
3221aab
This was referenced Dec 29, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VelikovPetar VelikovPetar VelikovPetar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gpunto @VelikovPetar