stream-chat-android-client/src/main/java/io/getstream/chat/android/client/notifications/handler/MessagingStyleNotificationHandler.kt (1)

72-83: Good lazy initialization to defer notification channel creation.

Converting factory to lazy initialization ensures the notification channel is only created when notifications are actually displayed, not during handler construction. Since factory accesses the lazy notificationManager (which creates the channel), and factory is only used in showNotification* and dismissChannelNotifications methods, this correctly defers channel creation until needed.

Optional: Add explanatory comment

Consider adding a brief comment explaining the lazy initialization:

+    // Lazy initialization defers notification channel creation until first notification is shown
     private val factory: MessagingStyleNotificationFactory by lazy {
         MessagingStyleNotificationFactory(

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/di/ChatModule.kt (1)

128-128: Consider documenting the nullable notification handler parameter.

The nullable notificationsHandler parameter is a key part of the fix, allowing the default handler creation to be deferred. While the internal API status makes this acceptable, a brief KDoc comment would help future maintainers understand when this parameter should be null versus provided.

Optional: Add parameter documentation

  * @param notificationConfig Global client configuration including API key, endpoints, timeouts, and feature flags.
+ * @param notificationsHandler Optional custom notification handler. If null and pushNotificationsEnabled is true,
+ * a default handler will be created. If pushNotificationsEnabled is false, no handler is created regardless.
  * @param apiModelTransformers Transformers that map between network DTOs and domain models (in/outgoing).

As per coding guidelines, documenting internal APIs is optional, but this parameter's behavior is subtle enough that documentation would add value.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.