Fix StrictMode violations in the AttachmentsPicker#6029
Merged
Conversation
Contributor
SDK Size Comparison 📏
|
VelikovPetar
changed the title
StrictMode violations in the AttachmentsPicker
andremion
reviewed
Dec 10, 2025
...tream/chat/android/compose/ui/messages/attachments/factory/AttachmentsProcessingViewModel.kt
Show resolved
Hide resolved
...main/java/io/getstream/chat/android/compose/viewmodel/messages/AttachmentsPickerViewModel.kt
Show resolved
Hide resolved
|
andremion
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implements fixes for StrictMode violations (Read/Write disk on main thread) originating from the attachments picker.
Resolves: https://linear.app/stream/issue/AND-938/fix-strictmode-violations-in-attachmentspicker
🛠 Implementation details
AttachmentsProcessingViewModelwhich defers theStorageHelperWrapperoperations to a background thread.AttachmentsPickerFilesTabFactory,AttachmentsPickerImagesTabFactoryand inAttachmentsPickerSystemTabFactoryAttachmentsPickerViewModelAttachmentsPickercomposable to use the new asynchronous methods🎨 UI Changes
NA
🧪 Testing
ImagesorFilestab (or do the same withChatTheme(useDefaultSystemMediaPicker = true))