Prevent duplicate GetOrCreateChannel calls when paginating messages#6016
Merged
VelikovPetar merged 6 commits intodevelopfrom Nov 28, 2025
Merged
Conversation
Contributor
SDK Size Comparison 📏
|
andremion
reviewed
Nov 28, 2025
...in/kotlin/io/getstream/chat/android/ui/common/feature/messages/list/MessageListController.kt
Show resolved
Hide resolved
andremion
approved these changes
Nov 28, 2025
|
VelikovPetar
deleted the
bug/AND-917_prevent_duplicate_pagination_calls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Resolves two issues which can result in multiple unnecessary calls to
GetOrCreateChannelwhen paginating messages in a channel:loadOlderMessagesifMessageListControlleris already loading older messagesfillTheGapifChannelLogicis loading older/newer messages. In this case, there will be no gap to be filled, so any calls to it are redundant.🛠 Implementation details
loadingOlderMessagesinMessageListController.loadOlderMessagesChannelLogic.fillTheGapONLY when loading messages around ID (isFilteringAroundIdMessages)🎨 UI Changes
NA
🧪 Testing
GetOrCreateChannelcall (POST https://chat.stream-io-api.com/channels/<channelType>/<channelId>/query)